Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jsdom-env): remove Buffer #11241

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Mar 25, 2021

Summary

Following up on #11222. For some reason a JSDOM test takes about 12 seconds rather than less than 1 with this change. (slow enough that a test fails since it crosses the test length threshold, causing a snapshot diff)

Test plan

Green CI, eventually

@MichaelDeBoey
Copy link
Contributor

@codecov-io
Copy link

Codecov Report

Merging #11241 (167aad4) into master (167aad4) will not change coverage.
The diff coverage is n/a.

❗ Current head 167aad4 differs from pull request most recent head 412360d. Consider uploading reports for the commit 412360d to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master   #11241   +/-   ##
=======================================
  Coverage   64.24%   64.24%           
=======================================
  Files         308      308           
  Lines       13502    13502           
  Branches     3289     3289           
=======================================
  Hits         8675     8675           
  Misses       4117     4117           
  Partials      710      710           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 167aad4...412360d. Read the comment docs.

@ahnpnl

This comment has been minimized.

@SimenB

This comment has been minimized.

@ahnpnl

This comment has been minimized.

@SimenB

This comment has been minimized.

@ahnpnl

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants