-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(jsdom-env): remove Buffer #11241
base: main
Are you sure you want to change the base?
Conversation
This test should be deleted too I think? |
Codecov Report
@@ Coverage Diff @@
## master #11241 +/- ##
=======================================
Coverage 64.24% 64.24%
=======================================
Files 308 308
Lines 13502 13502
Branches 3289 3289
=======================================
Hits 8675 8675
Misses 4117 4117
Partials 710 710 Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
412360d
to
bbbaf4a
Compare
90cbe2d
to
9a374fd
Compare
Summary
Following up on #11222. For some reason a JSDOM test takes about 12 seconds rather than less than 1 with this change. (slow enough that a test fails since it crosses the test length threshold, causing a snapshot diff)
Test plan
Green CI, eventually