chore: revert #12718 and simply do not bundle type declarations of @jest/globals
#12721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
reviewed
Apr 23, 2022
F3n67u
pushed a commit
to F3n67u/jest
that referenced
this pull request
May 2, 2022
… of `@jest/globals` (jestjs#12721)
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Must admit, I made a wrong assumption in #12718. Apparently bundling of a single
.d.tsfile is nice idea: exported types get alphabetized and also Prettier makes it all more readable. There is no need of the code I introduced. Better to exclude problematic packages explicitly.For instance, it looks like there is no need of bundling for
'@jest/globals'.Here is
tscs output:After bundling:
Test plan
Green CI.