chore: do not bundle type definitions for packages which have only one .d.ts file
#12718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm.. This part of the script does not run on definition files which are not bundled (should it be split into separate step, perhaps?): |
SimenB
approved these changes
Apr 23, 2022
F3n67u
pushed a commit
to F3n67u/jest
that referenced
this pull request
May 2, 2022
F3n67u
pushed a commit
to F3n67u/jest
that referenced
this pull request
May 2, 2022
… of `@jest/globals` (jestjs#12721)
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What if type definitions of packages which have only one
.d.tsfile would not be bundled?First, there is nothing to bundle. Second, that could be an elegant workaround for: https://github.com/facebook/jest/blob/3c6f14bc51a857bb0baf8e6ff7af43aaf47951e9/packages/jest-expect/src/types.ts#L19-L20
In this case the problem was that the bundler is simply discarding
declare module 'expect'declaration. An attempt to havejest.Mockedwas hitting the same problem, becausedeclare namespace jestwas also thrown away.jest.Mockeddeclaration must live inside@jest/globals, which is just one tiny file. That’s why I though: wait, what is the bundler doing here? ;DTest plan
Green CI.