New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade sane and use FSEventsWatcher on Darwin #3902
Conversation
This is to fix regressions with the NodeWatcher on macOS. More info here: amasad/sane#97
Codecov Report
@@ Coverage Diff @@
## master #3902 +/- ##
=======================================
Coverage 58.01% 58.01%
=======================================
Files 195 195
Lines 6741 6741
Branches 6 6
=======================================
Hits 3911 3911
Misses 2827 2827
Partials 3 3
Continue to review full report at Codecov.
|
@@ -114,5 +114,8 @@ | |||
"testMatch": [ | |||
"**/*.test.js" | |||
] | |||
}, | |||
"dependencies": { | |||
"sane": "^2.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes!
Anybody wants to send a fix for this so we can get it into the next Jest release? |
Ask and you shall receive: #3918 |
Thanks! I sent this on go so couldn't update. Feel free to close this one. |
Anybody know when the next Jest version will be released with this fix? |
@kirkstrobeck you can use prerelease tagged |
@thymikee Unfortunately, getting errors on that Error: Cannot find module './state'
at Function.Module._resolveFilename (module.js:485:15)
at Function.Module._load (module.js:437:25)
at Module.require (module.js:513:17)
at require (internal/module.js:11:18)
at Object.<anonymous> (/node_modules/jest-snapshot/build/index.js:24:14)
at Module._compile (module.js:569:30)
at Object.Module._extensions..js (module.js:580:10)
at Module.load (module.js:503:32)
at tryModuleLoad (module.js:466:12)
at Function.Module._load (module.js:458:3)
error Command failed with exit code 1. |
Had this same error. I ran |
I can repro that fix.. What the .. lol |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This is to fix regressions with the NodeWatcher on macOS.
More info here: amasad/sane#97
Test plan