Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade sane and use FSEventsWatcher on Darwin #3902

Closed
wants to merge 1 commit into from
Closed

Upgrade sane and use FSEventsWatcher on Darwin #3902

wants to merge 1 commit into from

Conversation

amasad
Copy link
Contributor

@amasad amasad commented Jun 25, 2017

This is to fix regressions with the NodeWatcher on macOS.
More info here: amasad/sane#97

Test plan

  1. yarn test
  2. on macOS create a new dir and install a preposterous number of node_modules
  3. run jest tests in that directory using this branch

This is to fix regressions with the NodeWatcher on macOS.
More info here: amasad/sane#97
@codecov-io
Copy link

Codecov Report

Merging #3902 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3902   +/-   ##
=======================================
  Coverage   58.01%   58.01%           
=======================================
  Files         195      195           
  Lines        6741     6741           
  Branches        6        6           
=======================================
  Hits         3911     3911           
  Misses       2827     2827           
  Partials        3        3
Impacted Files Coverage Δ
packages/jest-haste-map/src/index.js 92.59% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04d05e5...7684498. Read the comment docs.

@@ -114,5 +114,8 @@
"testMatch": [
"**/*.test.js"
]
},
"dependencies": {
"sane": "^2.0.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes!

@cpojer
Copy link
Member

cpojer commented Jun 26, 2017

Anybody wants to send a fix for this so we can get it into the next Jest release?

@SimenB
Copy link
Member

SimenB commented Jun 26, 2017

Ask and you shall receive: #3918

@amasad
Copy link
Contributor Author

amasad commented Jun 26, 2017

Thanks! I sent this on go so couldn't update. Feel free to close this one.

@cpojer cpojer closed this Jun 27, 2017
@kirkstrobeck
Copy link

Anybody know when the next Jest version will be released with this fix?

@thymikee
Copy link
Collaborator

thymikee commented Jul 3, 2017

@kirkstrobeck you can use prerelease tagged jest@20.1.0-alpha.3

@kirkstrobeck
Copy link

kirkstrobeck commented Jul 3, 2017

@thymikee Unfortunately, getting errors on that

Error: Cannot find module './state'
    at Function.Module._resolveFilename (module.js:485:15)
    at Function.Module._load (module.js:437:25)
    at Module.require (module.js:513:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/node_modules/jest-snapshot/build/index.js:24:14)
    at Module._compile (module.js:569:30)
    at Object.Module._extensions..js (module.js:580:10)
    at Module.load (module.js:503:32)
    at tryModuleLoad (module.js:466:12)
    at Function.Module._load (module.js:458:3)
error Command failed with exit code 1.

@thymikee
Copy link
Collaborator

thymikee commented Jul 3, 2017

Had this same error. I ran yarn add once again and it clicked

@kirkstrobeck
Copy link

I can repro that fix.. What the .. lol

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants