Don’t subtract the number of test suites with runtime errors from the… #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… total. This is confusing. Assuming only two test suites have no-runtime errors here is the output: Previously: 77 tests failed, 8 test suites failed, 9 tests passed (86 total in 2 test suites, run time 3.33s) New: 77 tests failed, 8 test suites failed, 9 tests passed (86 total in 15 test suites, run time 3.33s) (I know this has nothing to do with node-haste, but it is annoying while I try to make the tests pass and I don’t know what’s up. Sue me!)
|
@facebook-github-bot shipit |
|
(This was reviewed by @amasad when we were going through the node-haste2 PR; I'm pulling this bugfix into jest 0.8.0). |
|
Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/403719976504881/int_phab to review. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… total. This is confusing.
Assuming only two test suites have no-runtime errors here is the output:
Previously: 77 tests failed, 8 test suites failed, 9 tests passed (86 total in 2 test suites, run time 3.33s)
New: 77 tests failed, 8 test suites failed, 9 tests passed (86 total in 15 test suites, run time 3.33s)