-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse describe blocks #7215
Parse describe blocks #7215
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7215 +/- ##
==========================================
+ Coverage 67.25% 67.46% +0.21%
==========================================
Files 248 249 +1
Lines 9641 9719 +78
Branches 3 3
==========================================
+ Hits 6484 6557 +73
- Misses 3156 3161 +5
Partials 1 1
Continue to review full report at Codecov.
|
Finally find the time to get this long-due feature in. This should help closing quite a few issues and unlock other cool features requested in vscode-jest... please take a look at your earliest convenience, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests look like I expect they would here - nice work
It's probably worth changing the lockfile access but other than that it's good from me
@@ -13407,7 +13407,7 @@ typedarray@^0.0.6: | |||
resolved "https://registry.yarnpkg.com/typedarray/-/typedarray-0.0.6.tgz#867ac74e3864187b1d3d47d996a78ec5c8830777" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the file access rights have changed on the lock file:100644 → 100755
might be an issue
Related: I have a chat with some of the jest core contributors, and we think it makes sense to move this out into it's own repo so that we can handle our own deploys and not block other PRs. It was in here originally so that we can make sure that the types in the JSON for comms between the extension and jest were stable, and it looks like it's not really changed in a year or so. So I think we're good to migrate it to jest-community, which I'm gonna look at next weekend |
@orta I completely agree, let's do it. I assume you will also include the |
2ed770d
to
483ca3a
Compare
483ca3a
to
fe7fe94
Compare
Yeah, I think that's a great idea! EDIT: Also, make sure to get publish access to those modules |
So I merged this PR into the new repo ( still working on getting tests passing on there, but a lot of it is green now ) - closing this PR |
Where can I follow this issue? I'd love to add a debug code lense to describe blocks in vscode-jest but I'd need the describe block parsing first. |
I don't think there is an issue to follow anymore @kjjgibson. The PR was merged in jest-community/jest-editor-support. |
Aha I see, thanks @seanpoulter. I guess vscode-jest needs to be updated to use the new jest-editor-support instead of the package removed from jest in v24. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
enhance test file parsers (js and typescript) to
describe
block and hierarchical relationship (vscode-jest #351, #321, #298, , #288, #281, #135)Test plan