Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Replaces findDomNode() with refs #9124

Merged
merged 1 commit into from Nov 2, 2019

Conversation

Abhi347
Copy link
Contributor

@Abhi347 Abhi347 commented Nov 2, 2019

Summary

As mentioned in #9043 usage of findDomeNode() is deprecated and have rule against its usage in ESLint. This PR Closes #9043 by removing findDomeNode() usage in the example and replaces it with createRef().

Since the test required accessing two different DOM nodes (label and input), ref forwarding is used for both of them

Test plan

yarn test

@Abhi347
Copy link
Contributor Author

Abhi347 commented Nov 2, 2019

I have no idea why those 2 tests are failing on installation. Will it work if we rerun the tests?

@Abhi347 Abhi347 marked this pull request as ready for review November 2, 2019 05:29
@SimenB
Copy link
Member

SimenB commented Nov 2, 2019

I restarted CI

@codecov-io
Copy link

codecov-io commented Nov 2, 2019

Codecov Report

Merging #9124 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9124   +/-   ##
=======================================
  Coverage   64.73%   64.73%           
=======================================
  Files         277      277           
  Lines       11709    11709           
  Branches     2875     2875           
=======================================
  Hits         7580     7580           
  Misses       3512     3512           
  Partials      617      617

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a9dbf2...4559276. Read the comment docs.

@SimenB SimenB merged commit 220835c into jestjs:master Nov 2, 2019
@SimenB
Copy link
Member

SimenB commented Nov 2, 2019

Thanks!

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

findDomNode is deprecated
4 participants