chore: replace findDOMNode() in examples/typescript
#9300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I imitated #9124 commit which is about deprcated findDomNode() using Typescript. Plus, I refactored sum.ts and sub.ts with arrow functions
Codecov Report
@@ Coverage Diff @@
## master #9300 +/- ##
=======================================
Coverage 64.99% 64.99%
=======================================
Files 278 278
Lines 11912 11912
Branches 2934 2935 +1
=======================================
Hits 7742 7742
Misses 3539 3539
Partials 631 631Continue to review full report at Codecov.
|
SimenB
changed the title
findDOMNode() in examples/typescript
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I imitated #9124 commit which is about deprcated findDomNode() using Typescript.
Plus, I refactored sum.ts and sub.ts with arrow functions.
Test plan
yarn test
This is my first pull request. If you have any advice, please do it for me.