Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade to fsevents 2 #9215

Merged
merged 2 commits into from Nov 20, 2019
Merged

chore: upgrade to fsevents 2 #9215

merged 2 commits into from Nov 20, 2019

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Nov 20, 2019

Summary

Fixes #9191.

Test plan

I tested this on my own mac (with --no-watchman) - seemed to work out great 🙂

@codecov-io
Copy link

Codecov Report

Merging #9215 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9215      +/-   ##
==========================================
+ Coverage   65.08%   65.09%   +<.01%     
==========================================
  Files         278      278              
  Lines       11861    11860       -1     
  Branches     2922     2921       -1     
==========================================
  Hits         7720     7720              
+ Misses       3512     3511       -1     
  Partials      629      629
Impacted Files Coverage Δ
packages/jest-haste-map/src/lib/FSEventsWatcher.ts 12.72% <0%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fafb5b7...eca03a9. Read the comment docs.

@SimenB SimenB merged commit d4e2d84 into jestjs:master Nov 20, 2019
@SimenB SimenB deleted the fsevents branch November 20, 2019 23:19
ayush000 added a commit to ayush000/jest that referenced this pull request Nov 21, 2019
@ayush000
Merge branch 'master' into patch-1
445cf6d 
* master:
  chore: upgrade to fsevents 2 (jestjs#9215)
  docs: remove expect.assertions(1) in rejects example of Tutoria… (jestjs#9149)
  chore: bump to istanbul alphas (jestjs#9192)
  Fix typo in JestPlatform.md (jestjs#9212)
  jest-snapshot: Ignore indentation for most serialized objects (jestjs#9203)
  fix(jest-types): tighten Config types and set more defaults (jestjs#9200)
  jest-snapshot: Improve colors when snapshots are updatable (jestjs#9132)
  jest-snapshot: Omit irrelevant received properties when property matchers fail (jestjs#9198)
  chore: make changedFiles option optional in `shouldInstrument` (jestjs#9197)
  fix(pretty-format): correctly detect memo (jestjs#9196)
  chore: regenerate lockfiles in e2e tests (jestjs#9193)
  chore: bump handlebars
@benjamn
Copy link
Contributor

benjamn commented Jan 2, 2020 •
edited

@SimenB Could you release a new version of jest-haste-map with this change soon? Right now, npm install fails with jest-haste-map@24.9.0 and Node 12, because this change is not in 24.9.0.

@benjamn benjamn mentioned this pull request Jan 2, 2020
Closed
@SimenB
Copy link
Member Author

SimenB commented Jan 2, 2020

I'll try to poke some fb people to make a release, I don't have access.

It's under optionalDependencies though, so the install shouldn't fail even if fsevents fails to install (and if it's missing, jest-haste-map will fallback to a node based watcher)

@benjamn
Copy link
Contributor

benjamn commented Jan 2, 2020

Thanks for the comment! I was just about to post an update that npm i fsevents@latest fixed the problem in my project, apparently because npm won't try to install an optional transitive dependency if a more recent version is directly installed in the top-level node_modules directory. So this is a little less urgent than I thought at first.

@SimenB
Copy link
Member Author

SimenB commented Jan 2, 2020

The apis are different, so if jest ends up using v2 it'll explode. Sounds like an npm bug... If you've got Watchman installed it won't be used though, so you should be good

benjamn added a commit to apollographql/apollo-client that referenced this pull request Jan 3, 2020
@benjamn
Update fsevents to latest version so jest-haste-map won't install it.
1deb021 
jestjs/jest#9215 (comment)
@tracker1 tracker1 mentioned this pull request Jan 21, 2020
Closed
This was referenced Jan 28, 2020
Open
Open
This was referenced Feb 4, 2020
Open
Open
Open
Open
This was referenced Feb 18, 2020
Open
Open
Open
@Leko Leko mentioned this pull request Feb 25, 2020
Open
This was referenced Mar 3, 2020
Open
Open
This was referenced Mar 10, 2020
Open
Open
This was referenced Mar 17, 2020
Open
Open
@snyk-bot snyk-bot mentioned this pull request Mar 21, 2020
Closed
This was referenced Mar 24, 2020
Open
Open
This was referenced Apr 16, 2020
Open
Open
Merged
Closed
Merged
This was referenced Apr 30, 2020
Closed
Closed
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thymikee thymikee thymikee approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade to fsevent v2 - Node 13 support
5 participants
@SimenB @codecov-io @benjamn @thymikee @facebook-github-bot