docs: remove expect.assertions(1) in rejects example of TutorialAsync.md #9149
Conversation
|
Hi Jongmun-Park! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Codecov Report
@@ Coverage Diff @@
## master #9149 +/- ##
=======================================
Coverage 64.77% 64.77%
=======================================
Files 277 277
Lines 11724 11724
Branches 2879 2878 -1
=======================================
Hits 7594 7594
Misses 3512 3512
Partials 618 618Continue to review full report at Codecov.
|
|
Hi, thanks for the PR! We had another one doing this where we suggested adding a clarifying comment instead of removing the line, if you want to read through that and maybe change this PR to do it that way that'd be great :) |
|
Thanks @jeysal |
|
Yes, perhaps explaining more in detail that it is otherwise easy to forget to |
* master: chore: upgrade to fsevents 2 (jestjs#9215) docs: remove expect.assertions(1) in rejects example of Tutoria… (jestjs#9149) chore: bump to istanbul alphas (jestjs#9192) Fix typo in JestPlatform.md (jestjs#9212) jest-snapshot: Ignore indentation for most serialized objects (jestjs#9203) fix(jest-types): tighten Config types and set more defaults (jestjs#9200) jest-snapshot: Improve colors when snapshots are updatable (jestjs#9132) jest-snapshot: Omit irrelevant received properties when property matchers fail (jestjs#9198) chore: make changedFiles option optional in `shouldInstrument` (jestjs#9197) fix(pretty-format): correctly detect memo (jestjs#9196) chore: regenerate lockfiles in e2e tests (jestjs#9193) chore: bump handlebars
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Hi.
a few days ago, i registered issue #9143
please, read that issue.
i suggest how about removing expect.assertions(1); code in rejects example of TutorialAsync.md
becauese i was not sure whether I should used assertions.
thank u.