Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix some type errors in e2e tests #9720

Merged
merged 2 commits into from
Mar 28, 2020
Merged

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Mar 28, 2020

Summary

This is far from perfect, but it's better than nothing 🙂 We don't actually typecheck these, so it's solely for local DX as the squigglies are annoying

Test plan

Green CI

@codecov-io
Copy link

Codecov Report

Merging #9720 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9720      +/-   ##
==========================================
+ Coverage   64.93%   64.95%   +0.01%     
==========================================
  Files         288      288              
  Lines       12190    12190              
  Branches     3023     3023              
==========================================
+ Hits         7916     7918       +2     
+ Misses       3636     3635       -1     
+ Partials      638      637       -1     
Impacted Files Coverage Δ
packages/expect/src/utils.ts 96.22% <0.00%> (+1.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db055c2...90f086c. Read the comment docs.

@SimenB SimenB merged commit b7cd432 into jestjs:master Mar 28, 2020
@SimenB SimenB deleted the e2e-types branch March 28, 2020 09:44
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants