Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contracted AcoustID 6 character width horrible loop in loop compute completely freezing the browser #387

Closed
jesus2099 opened this issue Feb 28, 2018 · 4 comments
Closed

Contracted AcoustID 6 character width horrible loop in loop compute completely freezing the browser #387

jesus2099 opened this issue Feb 28, 2018 · 4 comments
Labels
bug major mb_INLINE-STUFF
Milestone
2019

Comments

@jesus2099
Copy link
Owner

Really strange things happen today… #386 and now INLINE STUFF would not let a release page complete without freezing Vivaldi (Chrome)’s tab!
@jesus2099
Copy link
Owner Author

jesus2099 commented Feb 28, 2018 •
edited
Loading

Even stranger!

https://musicbrainz.org/release/5969be5e-c541-3c2b-b1e1-1fc58ff9817d works but https://musicbrainz.org/release/dd60e0db-c4a7-4a74-a2fc-3939e6619db7 and https://musicbrainz.org/release/b8f23db5-bbaa-4e5d-b8b1-dd122b4dd670 don’t!

@jesus2099 jesus2099 added this to the 2019 milestone Dec 6, 2018
@jesus2099
Copy link
Owner Author

@mitch2323 found the reason (or one of the reasons)!!
https://community.metabrainz.org/t/remove-acoustids-from-silence/411000?u=jesus2099

@jesus2099
Copy link
Owner Author

Work‐around found:

Change this line:

konami-command/mb_INLINE-STUFF.user.js

Line 57 in 526ba07

var contractFingerPrints = true; /* more compact AcoustIDs but brwoser can still inline search/find full AcoustID */

Into:

    var contractFingerPrints = false; /* more compact AcoustIDs but brwoser can still inline search/find full AcoustID */

@jesus2099
Copy link
Owner Author

It’s fixed now with a huge performance boost, as well!

@jesus2099 jesus2099 changed the title Completely freezing the browser Contracted AcoustID 6 character width horrible loop in loop compute completely freezing the browser Dec 31, 2018
jesus2099 added a commit that referenced this issue Aug 21, 2019
@jesus2099
FIX #387: Completely freezing the browser
dc04968 
Huge performance boost as well.
This contractFingerPrints 6 character width calculator had to be:
- extracted from loop in loop,
- not computed any more as I now use the ch(aracter width) unit
  (could be computed only once if I want to regain support for Opera presto I guess)
- set as a global style rule instead of inline style property
jesus2099 added a commit that referenced this issue Aug 21, 2019
@jesus2099
FIX #387: Completely freezing the browser
86d20ca 
Huge performance boost as well.
This contractFingerPrints 6 character width calculator had to be:
- extracted from loop in loop,
- not computed any more as I now use the ch(aracter width) unit
  (could be computed only once if I want to regain support for Opera presto I guess)
- set as a global style rule instead of inline style property
jesus2099 added a commit that referenced this issue Aug 21, 2019
@jesus2099
FIX #387: Completely freezing the browser
4de7d86 
Huge performance boost as well.
This contractFingerPrints 6 character width calculator had to be:
- extracted from loop in loop,
- not computed any more as I now use the ch(aracter width) unit
  (could be computed only once if I want to regain support for Opera presto I guess)
- set as a global style rule instead of inline style property
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug major mb_INLINE-STUFF
Projects
None yet
Milestone
2019
Development

No branches or pull requests
1 participant
@jesus2099