Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No more info on recording merge page #518

Closed
jesus2099 opened this issue Sep 25, 2020 · 5 comments
Closed

No more info on recording merge page #518

jesus2099 opened this issue Sep 25, 2020 · 5 comments
Labels
mb_MERGE-HELPOR-2 react-hydrate new hint: custom mb-hydration event server change
Milestone
2020

Comments

@jesus2099
Copy link
Owner

jesus2099 commented Sep 25, 2020 •
edited

↖ #537 – [MBS] Adapt to React hydrate redraw of recording list

Recent Merge page migration to React fragments broke my script, like it broke COLLECTION HIGHLIGHTER (#517).
Reported by @supersentaidude and @dragonzeron.

I will wait a little to see if MBS can be fine-tuned to limit its impact on the AcoustID React fragment and not impact surrounding cells.
@jesus2099 jesus2099 changed the title React fragments broke the script React AcoustID fragment broke the surrounding cells Sep 25, 2020
@jesus2099 jesus2099 mentioned this issue Oct 18, 2020
Closed
@jesus2099
Copy link
Owner Author

Reported by @HibiscusKazeneko too now.

@jesus2099
Copy link
Owner Author

Follow fixing of this issue in #517 (priority ticket with same issue).

@jesus2099 jesus2099 changed the title React AcoustID fragment broke the surrounding cells No more info on recording merge page Nov 29, 2020
@jesus2099
Copy link
Owner Author

React AcoustID fragment broke the surrounding cells.
So it's only in recording merge page, I guess.

@jesus2099
Copy link
Owner Author

Related to #516.

jesus2099 added a commit that referenced this issue Nov 29, 2020
@jesus2099
Repair scripts with new React redraw on recording merge page
caec1d6 
AcoustID have been added on recording merge page
as dynamic React redraw. https://tickets.metabrainz.org/browse/MBS-2768

So I patched my scripts to wait for React redraws
finish (all p.loading-message disappear).

- mb. MERGE HELPOR 2 (regressions may appear)
- mb. COLLECTION HIGHLIGHTER

Fixes #517 and #518.
@jesus2099
Copy link
Owner Author

Here is the more clever diff: caec1d6?w=1#diff-3723f064788802dbda492533cef7bd027ad9aaedd73dbdec0adc54896ff54f14

This was referenced Nov 30, 2020
Closed
Closed
@jesus2099 jesus2099 added the react-hydrate new hint: custom mb-hydration event label Mar 5, 2021
@jesus2099 jesus2099 added this to the 2020 milestone Aug 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
mb_MERGE-HELPOR-2 react-hydrate new hint: custom mb-hydration event server change
Projects
None yet
Milestone
2020
Development

No branches or pull requests
1 participant
@jesus2099