Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button "Clear queue before add all/selected recordings for merge" disappeared #536

Closed
jesus2099 opened this issue Nov 30, 2020 · 1 comment
Labels
mb_MERGE-HELPOR-2 react-hydrate new hint: custom mb-hydration event server change
Milestone

Comments

@jesus2099
Copy link
Owner

jesus2099 commented Nov 30, 2020

MBS has introduced a new div.recording-list on top of the table.tbl.
Both in /artist/<mbdi>/recordings and in /recording/merge.

Other entities don't (yet?) have this new parent.

@jesus2099
Copy link
Owner Author

jesus2099 commented Nov 30, 2020

I see it comes from same MBS-2768 / metabrainz/musicbrainz-server#1586 as #517 and #518.

New div.recording-list and (deferred?) redrawing(/hydrate?) of its content:

metabrainz/musicbrainz-server@53fc7e3#diff-8faa5353a1c84c9ee6dcf90be9bd62c669390f97c07ad8cf8401a8cee0bc7a6fR137-R140

export default (hydrate<Props>(
  'div.recording-list',
  RecordingList,
): React.AbstractComponent<Props, void>);

@jesus2099 jesus2099 changed the title Butoon "Clear queue before add all/selected recordings for merge" disappeared Button "Clear queue before add all/selected recordings for merge" disappeared Nov 30, 2020
jesus2099 added a commit that referenced this issue Nov 30, 2020
caec1d6

Prevented edit note (#535)
And fix React redraw change that hid one of my buttons (#536).
@jesus2099 jesus2099 added the react-hydrate new hint: custom mb-hydration event label Mar 5, 2021
@jesus2099 jesus2099 added this to the 2021 milestone Aug 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mb_MERGE-HELPOR-2 react-hydrate new hint: custom mb-hydration event server change
Projects
None yet
Development

No branches or pull requests

1 participant