[WIP] Enable Sourcelink #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I found an issue with sourcelink in froto, seems |
|
The issue is that Rider and VS4Mac are using Mono and libgit2 native library is not loading right. They are working on a fix to trim the dependencies. dotnet/sourcelink#155 |
|
thx @ctaggart meanwhile i'll enable it only on windows in |
enricosada
force-pushed
the
sourcelink
branch
from
0374f5f
to
d525c2e
Compare
|
disabled it if run on mono msbuild. |
|
builds fine with Rider, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.