Don't initialize SQLAlchemy DB inside of jetkit #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
revmischa
changed the title
revmischa
changed the title
revmischa
requested review from
adamszeptycki,
gnudeb,
d-spiridonov and
paveu-piotrowski
and removed request for
adamszeptycki
adamszeptycki
approved these changes
Jan 1, 2020
paveu-piotrowski
approved these changes
Jan 2, 2020
gnudeb
approved these changes
Jan 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Organize and split up more DB functionality.
No longer do we initialize SQLAlchemy in JetKit - the app should do that itself. It's too major of a side effect for importing this library, and there was some other issue which I was trying to solve here that I've forgotten.
Almost working support for running bento in CI - you can run it manually if you like with
bento check.