Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for SSHFP, HINFO and LOC records #1

Merged
merged 1 commit into from
May 11, 2015

Conversation

markfqs
Copy link
Contributor

@markfqs markfqs commented Apr 21, 2015

Hi,

I found your web app the best and simplier to manage my set of DNS zones, but I needed support for some additional records, so I found usefull to add it and propose you to include it on your master ddevelopment.

Don't hesitate to comment anything on this (this is my first time using Git)

@jethrocarr
Copy link
Owner

Looks good, I'll review properly and merge this weekend :-) Thanks for the pull request!

@markfqs
Copy link
Contributor Author

markfqs commented Apr 22, 2015

Just after doing the pull request I found that the sql I attached to insert
the new records is incorrect (probably due some ALTER TABLE prior to that)
. I hope you will fix that quickly

If I had time I will try to include 2 new features:

  • Allow insert NS records using IP instead of FQDN (to avoid the need of
    glue records)
  • Make the agent to configure both primary (master) servers and Secondary
    (slave servers)

Thanks for your quick reply

2015-04-22 11:06 GMT+02:00 Jethro Carr notifications@github.com:

Looks good, I'll review properly and merge this weekend :-) Thanks for the
pull request!


Reply to this email directly or view it on GitHub
#1 (comment).

jethrocarr added a commit that referenced this pull request May 11, 2015
Added support for SSHFP, HINFO and LOC records
@jethrocarr jethrocarr merged commit 3a904d7 into jethrocarr:master May 11, 2015
@jethrocarr
Copy link
Owner

Merged and looking good, thanks for the contribution @markfqs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants