[perf] Improve install and ensure perf #2076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
savil
approved these changes
May 23, 2024
Comment on lines
+99
to
+100
| // if a store path is used as an installable, the keys will be present even if invalid but | ||
| // the values will be null. |
| for _, outValue := range out2 { | ||
| res = append(res, outValue.Path) | ||
| if outValue.Valid { |
gcurtis
approved these changes
May 23, 2024
mikeland73
added a commit
that referenced
this pull request
May 29, 2024
## Summary Fix regression introduced in #2076 I misunderstood the API. A null value (in modern API) or a valid: false (in legacy API) occur when store path doesn't exist. Whether the store path itself is a valid store path doesn't matter, obviously if it is not a valid path, it won't be present in the store, but if it's valid and not installed, it will return null value or valid: false. The users of this function do not want to ignore these paths. Edit: This bug is a bit less bad than initially thought. Because we install non-cached packages in flake, so anything missing would be installed then. ## How was it tested? Unit test. This is tricky to test. I added a test script that can hopefully catch this. Edit: This test doesn't actually catch this because the package ends up getting installed later on (in the flake). I still think this test is good to have.
mikeland73
added a commit
that referenced
this pull request
May 30, 2024
## Summary Addresses issue introduced in #2076 and #2098 Basically we have 2 different uses cases when looking up store paths. Sometimes we want all store paths (whether installed or not) and in other cases we only want paths that are in local store. This change fixes that and adds some testing. ## How was it tested? unit tests, manual integration test by installing a package that was not in local store.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This improves install and ensure perf by making the following changes:
nix lscall is about 50ms)FillNarInfoCacheHow was it tested?
Installed large devbox.json (30+ packages) and used
DEVBOX_PRINT_EXEC_TIMEand observed almost all "prep" time disappear. prep time is the work devbox does before actually building the packages.