Increase ACME control loop & order creation back-off #1195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ff to 1h. Fire Event when Order fails. Signed-off-by: James Munnelly <james@munnelly.eu>
jetstack-bot
added
release-note
munnerz
added
the
area/acme
jetstack-bot
added
the
size/S
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kragniz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jetstack-bot
added
the
approved
@munnerz want to open an issue for this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In future I'd like to make (3) also exponentially back-off as-per the Let's Encrypt client guidelines. This will require us to record more information about how many failures have passed, so I am deferring this for now.
(1) should also help reduce the number of times we re-attempt calls to the ACME server. With a base of 5s and a max of 30m, we will quickly only be re-attempting client calls every 30 minutes in the event they are persistently failing (i.e. due to certain endpoints hitting rate limits)
We are now able to use these higher numbers as a result of refactoring the way we use errors in the ACME orders & challenges process. For normal operation, this should be a non-issue for the majority of users. Only users who have got misconfigured setups will see long wait times.
Release note: