Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retain Challenge resources for debugging if an Order enters an invalid state #1197

Merged
merged 1 commit into from
Jan 11, 2019
Merged

Retain Challenge resources for debugging if an Order enters an invalid state #1197

merged 1 commit into from
Jan 11, 2019

Conversation

munnerz
Copy link
Member

@munnerz munnerz commented Jan 11, 2019

What this PR does / why we need it:

Previously we deleted all Challenge resources for an Order once the Order enters any 'final' state (including failed).

This makes it harder for users to debug order failures once the order transitions to the invalid state.

@goblain brought this up on slack: https://kubernetes.slack.com/archives/C4NV3DWUC/p1547213252391000

any idea how can I force cert-manager to keep challenge response open for debugging access to it ?

Release note:

Retain Challenge resources when an Order has entered a failed state to make debugging easier

/area provider-acme

@munnerz
Retain Challenge resources for debugging if an Order enters an invali…
b1df71d 
…d state

Signed-off-by: James Munnelly <james@munnelly.eu>
@jetstack-bot jetstack-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/acme Indicates a PR directly modifies the ACME Issuer code dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. labels Jan 11, 2019
@jetstack-bot jetstack-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 11, 2019
@munnerz munnerz added this to the v0.6 milestone Jan 11, 2019
kragniz
kragniz approved these changes Jan 11, 2019
View reviewed changes
Copy link
Contributor

@kragniz kragniz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 11, 2019
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kragniz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2019
@jetstack-bot jetstack-bot merged commit 2fc68d9 into cert-manager:master Jan 11, 2019
@munnerz munnerz deleted the acme-retain-challenges branch January 29, 2019 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kragniz kragniz kragniz approved these changes

Assignees

@kragniz kragniz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/acme Indicates a PR directly modifies the ACME Issuer code dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v0.6
Development

Successfully merging this pull request may close these issues.
3 participants
@munnerz @jetstack-bot @kragniz