Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add service account annotations to helm chart #2086

Merged

Conversation

serialx
Copy link
Contributor

@serialx serialx commented Sep 20, 2019

Signed-off-by: Brian Hong sungjinhong@devsisters.com

What this PR does / why we need it:
Add service account annotation support to helm chart. In order to use AWS EKS IAM Roles for Service Accounts feature, one must annotate the service account to specify what IAM role admin wants to grant to that service account.

apiVersion: v1
kind: ServiceAccount
metadata:
  annotations:
    eks.amazonaws.com/role-arn: arn:aws:iam::AWS_ACCOUNT_ID:role/IAM_ROLE_NAME

This PR is a QoL patch to enable helm created service accounts to have the annotation required above.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged):
Relates to #2048

Special notes for your reviewer:
I've successfully issues Certificates by using this PR in conjunction with #2083

Release note:

Service account annotation support in Helm chart

@jetstack-bot jetstack-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. labels Sep 20, 2019
@jetstack-bot jetstack-bot added the area/deploy Indicates a PR modifies deployment configuration label Sep 20, 2019
@jetstack-bot
Copy link
Contributor

Hi @serialx. Thanks for your PR.

I'm waiting for a jetstack or cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 20, 2019
@serialx
Copy link
Contributor Author

serialx commented Sep 20, 2019

Will it be possible for me to have test permissions to fast-track CI testing? :)

@munnerz
Copy link
Member

munnerz commented Sep 20, 2019

Will it be possible for me to have test permissions to fast-track CI testing? :)

Members of the cert-manager repository (added as 'collaborators') can skip the ok-to-test requirement - we don't have a well defined process for this yet, but if you're making a few contributions I'm happy to get you invited 😄.

/ok-to-test

@jetstack-bot jetstack-bot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 20, 2019
Signed-off-by: Brian Hong <sungjinhong@devsisters.com>
@jetstack-bot jetstack-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 20, 2019
@serialx
Copy link
Contributor Author

serialx commented Sep 20, 2019

Removed the annotation from webhook templates.

/retest

@serialx
Copy link
Contributor Author

serialx commented Sep 20, 2019

/retest

1 similar comment
@serialx
Copy link
Contributor Author

serialx commented Sep 23, 2019

/retest

@serialx
Copy link
Contributor Author

serialx commented Sep 23, 2019

Hmm..
/retest

@serialx
Copy link
Contributor Author

serialx commented Sep 23, 2019

/retest

1 similar comment
@serialx
Copy link
Contributor Author

serialx commented Sep 23, 2019

/retest

@munnerz
Copy link
Member

munnerz commented Sep 23, 2019

Thanks! 😄

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2019
@munnerz
Copy link
Member

munnerz commented Sep 24, 2019

/approve

@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: munnerz, serialx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 24, 2019
@retest-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to jetstack).
Review the full test history for this PR.
Silence the bot with an /lgtm cancel comment for consistent failures.

@retest-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to jetstack).
Review the full test history for this PR.
Silence the bot with an /lgtm cancel comment for consistent failures.

1 similar comment
@retest-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to jetstack).
Review the full test history for this PR.
Silence the bot with an /lgtm cancel comment for consistent failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/deploy Indicates a PR modifies deployment configuration dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. ok-to-test release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants