-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add service account annotations to helm chart #2086
Add service account annotations to helm chart #2086
Conversation
Hi @serialx. Thanks for your PR. I'm waiting for a jetstack or cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Will it be possible for me to have test permissions to fast-track CI testing? :) |
deploy/charts/cert-manager/templates/webhook-serviceaccount.yaml
Outdated
Show resolved
Hide resolved
Members of the cert-manager repository (added as 'collaborators') can skip the ok-to-test requirement - we don't have a well defined process for this yet, but if you're making a few contributions I'm happy to get you invited 😄. /ok-to-test |
Signed-off-by: Brian Hong <sungjinhong@devsisters.com>
977f1c4
to
520d9bd
Compare
Removed the annotation from webhook templates. /retest |
/retest |
1 similar comment
/retest |
Hmm.. |
/retest |
1 similar comment
/retest |
Thanks! 😄 /lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: munnerz, serialx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/retest |
1 similar comment
/retest |
Signed-off-by: Brian Hong sungjinhong@devsisters.com
What this PR does / why we need it:
Add service account annotation support to helm chart. In order to use AWS EKS IAM Roles for Service Accounts feature, one must annotate the service account to specify what IAM role admin wants to grant to that service account.
This PR is a QoL patch to enable helm created service accounts to have the annotation required above.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged):Relates to #2048
Special notes for your reviewer:
I've successfully issues Certificates by using this PR in conjunction with #2083
Release note: