Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand deployment docs, including docs on ingress-shim #264

Merged
merged 5 commits into from Jan 18, 2018
Merged

Expand deployment docs, including docs on ingress-shim #264

merged 5 commits into from Jan 18, 2018

Conversation

munnerz
Copy link
Member

@munnerz munnerz commented Jan 18, 2018 •
edited

What this PR does / why we need it:

Improves our documentation to further explain how Helm deployment works (including RBAC and extraArgs).

It also adds a doc on ingress-shim - what it does, how it works, how to configure it and how to use it.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Fixes #256, fixes #257, fixes #136

Release note:

Improve deployment documentation

/cc @ahmetb

@jetstack-bot
Copy link
Collaborator

@munnerz: GitHub didn't allow me to request PR reviews from the following users: ahmetb.

Note that only jetstack members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

What this PR does / why we need it:

Improves our documentation to further explain how Helm deployment works (including RBAC and extraArgs).

It also adds a doc on ingress-shim - what it does, how it works, how to configure it and how to use it.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Fixes #256, fixes #257

Release note:

Improve deployment documentation

/cc @ahmetb

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. retest-not-required-docs-only size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 18, 2018
@munnerz
Copy link
Member Author

munnerz commented Jan 18, 2018

I've now also updated this to include a migrating from kube-lego document @simonswine

@simonswine
Copy link
Contributor

Just gave it all a read (and tried migration from kube-lego, worked fine for me)
/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2018
@jetstack-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: simonswine

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@jetstack-ci-bot jetstack-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2018
@jetstack-ci-bot
Copy link
Contributor

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@jetstack-ci-bot jetstack-ci-bot merged commit 82c3c7b into cert-manager:master Jan 18, 2018
@munnerz munnerz mentioned this pull request Jan 18, 2018
Merged
jetstack-ci-bot added a commit that referenced this pull request Jan 18, 2018
@jetstack-ci-bot
Merge pull request #266 from munnerz/deploying-doc
6edb70b 
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Add links to new documentation content

**What this PR does / why we need it**:

After #264, this adds links to the new docs in our main README.

**Release note**:
```release-note
NONE
```
@munnerz munnerz mentioned this pull request Jan 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@simonswine simonswine

@dippynark dippynark

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
6 participants
@munnerz @jetstack-bot @simonswine @jetstack-ci-bot @jeff-knurek @dippynark