Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump vcert to v4.9.3 #2663

Merged
merged 1 commit into from
Mar 11, 2020
Merged

Bump vcert to v4.9.3 #2663

merged 1 commit into from
Mar 11, 2020

Conversation

munnerz
Copy link
Member

@munnerz munnerz commented Mar 6, 2020

What this PR does / why we need it:

We need to bump our dependency on vcert in order to support custom fields in TPP 19.2.

I'm not actually certain that this revision includes this patch as I can't find a PR that looks relevant/related, so for the time being and for safeties sake, I have bumped us now in the hopes it is just hidden in some recent PRs 😅

Release note:

Bump Venafi/vcert dependency to support custom fields in Venafi TPP 19.2

/kind cleanup
/milestone v0.14

@jetstack-bot jetstack-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Mar 6, 2020
@jetstack-bot jetstack-bot added this to the v0.14 milestone Mar 6, 2020
@jetstack-bot jetstack-bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Mar 6, 2020
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: munnerz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2020
@munnerz
Copy link
Member Author

munnerz commented Mar 6, 2020

/assign @meyskens

@jetstack-bot jetstack-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 6, 2020
@munnerz
Copy link
Member Author

munnerz commented Mar 6, 2020

This is the PR that we are waiting on: Venafi/vcert#87

/hold

@jetstack-bot jetstack-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 6, 2020
Signed-off-by: James Munnelly <james@munnelly.eu>
@munnerz munnerz changed the title Bump vcert to HEAD of master Bump vcert to v4.9.3 Mar 11, 2020
@munnerz
Copy link
Member Author

munnerz commented Mar 11, 2020

Updated to included the required fix 😄

/unhold
/cc @meyskens

@jetstack-bot jetstack-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 11, 2020
@meyskens
Copy link
Contributor

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 11, 2020
@jetstack-bot jetstack-bot merged commit 2dcc597 into cert-manager:master Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants