Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-0.14] Use correct service name in the --webhook-dns-names flag #2735

Merged
merged 1 commit into from
Mar 24, 2020
Merged

[release-0.14] Use correct service name in the --webhook-dns-names flag #2735

merged 1 commit into from
Mar 24, 2020

Conversation

jetstack-bot
Copy link
Contributor

This is an automated cherry-pick of #2733

/assign munnerz

Fix incorrect service name being used in the --webhook-dns-names flag

@munnerz
Use correct service name in the --webhook-dns-names flag
3096758 
Signed-off-by: James Munnelly <james@munnelly.eu>
@jetstack-bot jetstack-bot mentioned this pull request Mar 24, 2020
Merged
@jetstack-bot jetstack-bot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Mar 24, 2020
@jetstack-bot jetstack-bot added this to the v0.14 milestone Mar 24, 2020
@jetstack-bot jetstack-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Mar 24, 2020
@jetstack-bot jetstack-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/deploy Indicates a PR modifies deployment configuration labels Mar 24, 2020
@munnerz munnerz added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager and removed area/deploy Indicates a PR modifies deployment configuration do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 24, 2020
@munnerz
Copy link
Member

munnerz commented Mar 24, 2020

/kind bug
/lgtm
/approve

@jetstack-bot jetstack-bot added kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Mar 24, 2020
@jetstack-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jetstack-bot, munnerz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2020
@munnerz munnerz added area/deploy Indicates a PR modifies deployment configuration size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 24, 2020
@jetstack-bot jetstack-bot merged commit 54d6652 into cert-manager:release-0.14 Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@munnerz munnerz Awaiting requested review from munnerz

Assignees

@munnerz munnerz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/deploy Indicates a PR modifies deployment configuration cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v0.14
Development

Successfully merging this pull request may close these issues.
2 participants
@jetstack-bot @munnerz