-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release a tar.gz for the CLI tool #2871
Conversation
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: meyskens The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
@@ -2,7 +2,6 @@ package(default_visibility = ["//visibility:public"]) | |||
|
|||
load("@io_k8s_repo_infra//defs:build.bzl", "release_filegroup") | |||
load(":container.bzl", "multi_arch_container", "multi_arch_container_push") | |||
load(":platforms.bzl", "SERVER_PLATFORMS", "UBI_PLATFORMS", "for_platforms") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to keep SERVER_PLATFORMS
and for_platforms
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ooops...
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
/lgtm |
/kind cleanup To be unheld if it is passing 😄 |
/hold cancel |
/retest |
What this PR does / why we need it:
In order to use Krew we need the binaries tar gzipped
Release note: