Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for ctl convert over a list #3205

Merged
merged 5 commits into from
Aug 21, 2020
Merged

Add support for ctl convert over a list #3205

merged 5 commits into from
Aug 21, 2020

Conversation

JoshVanL
Copy link
Contributor

This PR adds support for ctl convert over a Kubernetes List object.

Adds integration tests for Lists.

I also moved all test data into a neater directory structure, since we were half half using inline, and file.

Add support for ctl convert over a list

/assign @meyskens

@JoshVanL
Move all input and output ctl convert integration test data into file
55566c2 
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
@JoshVanL
Add support for ctl covert with List
1c9e955 
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
@JoshVanL
Adds integration tests for ctl convert over a list
096962e 
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
@JoshVanL
Remove bad error text output
d3e2790 
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
@jetstack-bot jetstack-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 21, 2020
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoshVanL

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added area/testing Issues relating to testing approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 21, 2020
@JoshVanL
Updates deps
3ed1dfd 
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
@meyskens
Copy link
Contributor

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 21, 2020
@meyskens
Copy link
Contributor

/kind feature

@jetstack-bot jetstack-bot added kind/feature Categorizes issue or PR as related to a new feature. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Aug 21, 2020
@jetstack-bot jetstack-bot merged commit 85a9044 into cert-manager:master Aug 21, 2020
@jetstack-bot jetstack-bot added this to the v1.0 milestone Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@munnerz munnerz Awaiting requested review from munnerz

Assignees

@meyskens meyskens

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/testing Issues relating to testing dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@JoshVanL @jetstack-bot @meyskens