-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add -s and -w flags to the go_binary linkopts #4169
Conversation
Signed-off-by: Inteon <42113979+inteon@users.noreply.github.com>
Hi @inteon. Thanks for your PR. I'm waiting for a jetstack or cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Signed-off-by: Inteon <42113979+inteon@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: inteon, jakexks The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We have an internal project where we create an alternative build of cert-manager linked against some C libraries. One of the checks that verify that build tests that it has been linked against the correct libraries etc (using goversion and go tool nm).
We don't really have a feasible alternative way to do those tests now. |
What this PR does / why we need it:
Based on https://blog.filippo.io/shrink-your-go-binaries-with-this-one-weird-trick/, adding -s and -w flags as go_binary linkops arguments reduces the binary size.
From the article:
The cert-manager kubectl plugin's size shrinks from 68M to 43M.
Kubernetes also applies these flags when compiling their binaries; https://github.com/kubernetes/kubernetes/blob/1861e4756df1818a2d4ca60c869780bf742fff6b/hack/lib/golang.sh#L798-L804.
Release note:
/kind feature