-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use 'kubectl cert-manager check api' in verify-upgrade.sh #4218
Use 'kubectl cert-manager check api' in verify-upgrade.sh #4218
Conversation
Signed-off-by: Inteon <42113979+inteon@users.noreply.github.com>
Hi @inteon. Thanks for your PR. I'm waiting for a jetstack or cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/assign |
/test pull-cert-manager-upgrade-v1-21 |
|
upgrade test should now be fixed /test pull-cert-manager-upgrade-v1-21 |
Thank you for this PR @inteon ! /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: inteon, irbekrm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
In #4205 the 'kubectl cert-manager check api' was introduced.
This can be used in
verify-upgrade.sh
and simplify that script.Release note:
/kind cleanup