Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use 'kubectl cert-manager check api' in verify-upgrade.sh #4218

Merged
merged 1 commit into from
Jul 21, 2021
Merged

Use 'kubectl cert-manager check api' in verify-upgrade.sh #4218

merged 1 commit into from
Jul 21, 2021

Conversation

inteon
Copy link
Member

@inteon inteon commented Jul 16, 2021

What this PR does / why we need it:
In #4205 the 'kubectl cert-manager check api' was introduced.
This can be used in verify-upgrade.sh and simplify that script.

Release note:

/kind cleanup

@inteon
use 'kubectl cert-manager check api' in verify-upgrade.sh
629924c 
Signed-off-by: Inteon <42113979+inteon@users.noreply.github.com>
@jetstack-bot jetstack-bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 16, 2021
@jetstack-bot
Copy link
Contributor

Hi @inteon. Thanks for your PR.

I'm waiting for a jetstack or cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 16, 2021
@wallrj
Copy link
Member

wallrj commented Jul 16, 2021

/ok-to-test

@jetstack-bot jetstack-bot added ok-to-test release-note-none Denotes a PR that doesn't merit a release note. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 16, 2021
@irbekrm
Copy link
Contributor

irbekrm commented Jul 21, 2021

/assign

@irbekrm
Copy link
Contributor

irbekrm commented Jul 21, 2021

/test pull-cert-manager-upgrade-v1-21

@irbekrm
Copy link
Contributor

irbekrm commented Jul 21, 2021 •
edited
Loading

Testing upgrade from v1.5.0 to v1.5.0-alpha.0.16+624c9648e13745

From the test logs ^. Looks like this somehow picks up v1.5.0 tag, I assume this might be related to us accidentally releasing v1.5 earlier, if we did also tag the cert-manager repo with v1.5.0 tag then it may be cached by Bazel in CI - I cannot reproduce this failure locally.
Ignore that- the logic in how we calculate the last release is wrong 😄 . I'll fix that and then we can merge this

This was referenced Jul 21, 2021
Merged
Merged
@irbekrm
Copy link
Contributor

irbekrm commented Jul 21, 2021

upgrade test should now be fixed

/test pull-cert-manager-upgrade-v1-21

@irbekrm
Copy link
Contributor

irbekrm commented Jul 21, 2021

Thank you for this PR @inteon !

/approve
/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2021
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon, irbekrm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2021
@jetstack-bot jetstack-bot merged commit 05cfd7b into cert-manager:master Jul 21, 2021
@jetstack-bot jetstack-bot added this to the v1.5 milestone Jul 21, 2021
@maelvls maelvls mentioned this pull request Mar 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@irbekrm irbekrm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. ok-to-test release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@inteon @jetstack-bot @wallrj @irbekrm