Upgrade k8s.io dependencies to v0.23.1

[munnerz]

What this PR does / why we need it:

This has also involved upgrading go-logr from a v0.X release to v1.X, which brings with it a significant change in that Logger is no longer an interface and is now a struct that wraps an interface.

They've also made NewContext and FromContext first-class functions in the logr package too, so we can (over time) remove our own in-built variants.

To better handle the interface/struct change, I've opted to change up some bits of the webhook that previously accepted a stopCh and a Log field set on them to use a context provided one instead. There's a few extra changes I want to do here to tidy this up/make it cleaner, but I don't want to explode this PR in complexity :)

Release note:

Upgrade Kubernetes dependencies to v0.23.1

fixes #4500

[jetstack-bot]

Hi @munnerz. Thanks for your PR.

I'm waiting for a jetstack member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[maelvls]

upgrading go-logr from a v0.X release to v1.X

I remember having issues with go-logr 1.2.0 and controller-runtime 0.10.x:

Update: ohh it seems like controller-runtime has upgraded to go-logr v1.2.0 too! Never mind my comment 😅

[munnerz]

I think the failures here are unrelated...

/retest

[munnerz]

upgrading go-logr from a v0.X release to v1.X

I remember having issues with go-logr 1.2.0 and controller-runtime 0.10.x:

Update: ohh it seems like controller-runtime has upgraded to go-logr v1.2.0 too! Never mind my comment 😅

In reference to your tweet, the reason why this one would be especially problematic is between v0.x and v1.x of a module, there's no change to the module path. For future versions (i.e. v2), logr would be available under both github.com/go-logr/logr and github.com/go-logr/logr/v2 (for the v2 version), and so we could import both and things would 'just work'.

This hasn't always been the case with some modules when they move between versions (e.g. klog), because klog has a singleton within it and it appears they have opted to not do anything clever to maintain compatibility/interoperability between module versions (I'm not 100% sure on the 'why' of that though). This is effectively breaking the go module contract as it should be possible to have various dependencies importing both versions (with one possibly providing a compatibility layer around the other).

[munnerz]

/kind cleanup

[irbekrm]

/assign

[wallrj]

I think this all looks good and I'm very glad that hack/update-codegen.sh no longer downloads so much.

/lgtm
/approve

[jetstack-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: munnerz, wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [munnerz,wallrj]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment