Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PR template to be simpler and mention allowing edits #4775

Merged
merged 2 commits into from Jan 25, 2022
Merged

Update PR template to be simpler and mention allowing edits #4775

merged 2 commits into from Jan 25, 2022

Conversation

SgtCoDFish
Copy link
Member

@SgtCoDFish SgtCoDFish commented Jan 24, 2022 •
edited

  1. Removes link to k8s contributor guidelines; they're way more complicated than what we require. We don't want to link to docs suggesting the user needs to sign the k8s CLA.
  2. Removes link to k8s "faster reviews" - again, waaaay more complicated than we need. We don't want to link to docs suggesting "File a Kubernetes Enhancement Proposal"
  3. Adds link to our contributor guidelines.
  4. Adds special note about DCO signoff since it's often something that people get confused about
  5. Adds a link explaining how to allow edits by maintainers, inspired by the DocSearch PR instructions.
  6. Removes a couple of headings that nobody ever followed; instead have simpler clearer headings
  7. Default to release-note-none. Maintainers can always edit PR descriptions to add a release note even if the PR submitter didn't. This way, the default case is mergeable and it's one less thing for people to have to worry about.
  8. Add a prepopulated section suggesting which "kind" labels are available and prompting the submitter to pick one
NONE

@SgtCoDFish
update PR template to be simpler and mention allowing edits
a5fcd70 
Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
@jetstack-bot jetstack-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 24, 2022
jakexks
jakexks approved these changes Jan 24, 2022
View reviewed changes
Copy link
Member

@jakexks jakexks left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

suggestion: add a /kind section with a corresponding brief explanation. I personally always forget it.

Ironically, this PR needs a kind.

@maelvls
Copy link
Member

maelvls commented Jan 24, 2022

Nice, thank you, Ashley, that's something I wished to do but never got around doing it! 🙏

/kind cleanup
/lgtm

@jetstack-bot jetstack-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jan 24, 2022
@jetstack-bot jetstack-bot added lgtm Indicates that a PR is ready to be merged. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jan 24, 2022
@maelvls
Copy link
Member

maelvls commented Jan 24, 2022

Ouch, this is not a PR that should require any test to be run, but go figure :(

/retest

@SgtCoDFish
Copy link
Member Author

Ironically, this PR needs a kind.

That makes the case for adding it very well, doesn't it? I'll add it now

/hold

@jetstack-bot jetstack-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed lgtm Indicates that a PR is ready to be merged. labels Jan 24, 2022
@SgtCoDFish
Copy link
Member Author

I've added a section for kinds, but I'm not really thrilled with it. Feedback appreciated.

/unhold

@jetstack-bot jetstack-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 24, 2022
@jetstack-bot jetstack-bot added kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature. kind/documentation Categorizes issue or PR as related to documentation. kind/design Categorizes issue or PR as related to design. kind/flake Categorizes issue or PR as related to a flaky test. labels Jan 24, 2022
@SgtCoDFish
add reminder about kinds
b0f8a6e 
this can't include actaul examples because they'd be picked up by prow

Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
@SgtCoDFish SgtCoDFish removed kind/bug Categorizes issue or PR as related to a bug. kind/design Categorizes issue or PR as related to design. kind/documentation Categorizes issue or PR as related to documentation. kind/feature Categorizes issue or PR as related to a new feature. labels Jan 24, 2022
@jetstack-bot
Copy link
Collaborator

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to jetstack).
Review the full test history for this PR.
Silence the bot with an /lgtm cancel comment for consistent failures.

19 similar comments
@jetstack-bot
Copy link
Collaborator

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to jetstack).
Review the full test history for this PR.
Silence the bot with an /lgtm cancel comment for consistent failures.

@jetstack-bot
Copy link
Collaborator

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to jetstack).
Review the full test history for this PR.
Silence the bot with an /lgtm cancel comment for consistent failures.

@jetstack-bot
Copy link
Collaborator

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to jetstack).
Review the full test history for this PR.
Silence the bot with an /lgtm cancel comment for consistent failures.

@jetstack-bot
Copy link
Collaborator

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to jetstack).
Review the full test history for this PR.
Silence the bot with an /lgtm cancel comment for consistent failures.

@jetstack-bot
Copy link
Collaborator

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to jetstack).
Review the full test history for this PR.
Silence the bot with an /lgtm cancel comment for consistent failures.

@jetstack-bot
Copy link
Collaborator

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to jetstack).
Review the full test history for this PR.
Silence the bot with an /lgtm cancel comment for consistent failures.

@jetstack-bot
Copy link
Collaborator

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to jetstack).
Review the full test history for this PR.
Silence the bot with an /lgtm cancel comment for consistent failures.

@jetstack-bot
Copy link
Collaborator

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to jetstack).
Review the full test history for this PR.
Silence the bot with an /lgtm cancel comment for consistent failures.

@jetstack-bot
Copy link
Collaborator

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to jetstack).
Review the full test history for this PR.
Silence the bot with an /lgtm cancel comment for consistent failures.

@jetstack-bot
Copy link
Collaborator

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to jetstack).
Review the full test history for this PR.
Silence the bot with an /lgtm cancel comment for consistent failures.

@jetstack-bot
Copy link
Collaborator

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to jetstack).
Review the full test history for this PR.
Silence the bot with an /lgtm cancel comment for consistent failures.

@jetstack-bot
Copy link
Collaborator

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to jetstack).
Review the full test history for this PR.
Silence the bot with an /lgtm cancel comment for consistent failures.

@jetstack-bot
Copy link
Collaborator

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to jetstack).
Review the full test history for this PR.
Silence the bot with an /lgtm cancel comment for consistent failures.

@jetstack-bot
Copy link
Collaborator

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to jetstack).
Review the full test history for this PR.
Silence the bot with an /lgtm cancel comment for consistent failures.

@jetstack-bot
Copy link
Collaborator

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to jetstack).
Review the full test history for this PR.
Silence the bot with an /lgtm cancel comment for consistent failures.

@jetstack-bot
Copy link
Collaborator

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to jetstack).
Review the full test history for this PR.
Silence the bot with an /lgtm cancel comment for consistent failures.

@jetstack-bot
Copy link
Collaborator

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to jetstack).
Review the full test history for this PR.
Silence the bot with an /lgtm cancel comment for consistent failures.

@jetstack-bot
Copy link
Collaborator

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to jetstack).
Review the full test history for this PR.
Silence the bot with an /lgtm cancel comment for consistent failures.

@jetstack-bot
Copy link
Collaborator

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to jetstack).
Review the full test history for this PR.
Silence the bot with an /lgtm cancel comment for consistent failures.

@jahrlin
Copy link
Contributor

jahrlin commented Jan 25, 2022

This is a great improvement, thanks!

/lgtm
/approve

@jetstack-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jahrlin, jakexks, SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [SgtCoDFish,jahrlin,jakexks]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot
Copy link
Collaborator

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to jetstack).
Review the full test history for this PR.
Silence the bot with an /lgtm cancel comment for consistent failures.

1 similar comment
@jetstack-bot
Copy link
Collaborator

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to jetstack).
Review the full test history for this PR.
Silence the bot with an /lgtm cancel comment for consistent failures.

@SgtCoDFish
Copy link
Member Author

/test pull-cert-manager-e2e-v1-23

@jetstack-bot
Copy link
Collaborator

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to jetstack).
Review the full test history for this PR.
Silence the bot with an /lgtm cancel comment for consistent failures.

@jetstack-bot jetstack-bot merged commit 83d722f into cert-manager:master Jan 25, 2022
@jetstack-bot jetstack-bot added this to the v1.7 milestone Jan 25, 2022
@SgtCoDFish SgtCoDFish deleted the prtemplate branch January 25, 2022 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakexks jakexks jakexks approved these changes

Assignees

@jakexks jakexks

@jahrlin jahrlin

@maelvls maelvls

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@SgtCoDFish @maelvls @jetstack-bot @jahrlin @jakexks