Add flag for number periods gathering/posting data #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jetstack-bot
added
the
dco-signoff: no
jetstack-bot
added
the
size/S
Number of periods is integer. Takes -1 as default (runs perpetually) - Any -ve will do this Signed-off-by: Jamie Leppard <JammyL@users.noreply.github.com>
jetstack-bot
added
dco-signoff: yes
james-w
reviewed
Jun 17, 2020
|
I've written up an issue here: #177 I'm aware it might be slightly different from the task, however I think it's worth having the discussion there about the requirements as I think there might be a simpler implementation with a minor adjustment in the requirements. I'll comment on the issue to chat more about that. (issue comment) |
jetstack-bot
added
the
needs-rebase
Signed-off-by: Jamie Leppard <JammyL@users.noreply.github.com>
jetstack-bot
removed
the
needs-rebase
|
/lgtm |
james-w
reviewed
Jun 18, 2020
Signed-off-by: Jamie Leppard <JammyL@users.noreply.github.com>
|
Looks good to me! /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: charlieegan3, JammyL The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jetstack-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Number of periods is integer.
Takes -1 as default (runs perpetually) - Any -ve will do this