Helm: the namespace was missing in the configmap, deployment, and serviceaccount templates #526
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Source: https://venafi.atlassian.net/browse/VC-32006
When installing with
helm install
, the namespace doesn't need to be present on the templates. Helm automatically installs the resources that don't have a specific namespace to the namespace specified in--namespace
.But when using
helm template
, the resulting templated manifests don't contain a namespace, even though--namespace
was used. This is an old issue of Helm (helm/helm#3553). And since a lot of people rely onhelm template
and then feed that into ArgoCD, it makes to add thenamespace
field to all namespaced resources.Thus, this PR adds the
namespace
in the configmap, deployment, and serviceaccount templates.Manual test for the chart
venafi-kubernetes-agent
:Result:
Manual test for the chart
jetstack-agent
:Result: