Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make command to fail if missing Rego definition #68

Merged
merged 2 commits into from Jan 30, 2020
Merged

Make command to fail if missing Rego definition #68

merged 2 commits into from Jan 30, 2020

Conversation

j-fuentes
Copy link
Member

This makes the command fail if a rule existed in the PolicyManifest but it was not found in the Rego package.

Since the reports are still useful, it does not fail hard and finished the execution after generating the reports.

Signed-off-by: Jose Fuentes jsfuentescastillo@gmail.com

@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 28, 2020
@charlieegan3
Copy link
Contributor

/approve

@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: charlieegan3, j-fuentes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [charlieegan3,j-fuentes]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@charlieegan3
Copy link
Contributor

All looking good to me - think it makes sense to error in this case as it's a misconfiguration case I think we'd always want to avoid.

Minor edit to the message, then I can lgtm

@jetstack-bot jetstack-bot added dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Jan 29, 2020
j-fuentes and others added 2 commits January 29, 2020 15:46
@j-fuentes
Make command to fail if missing rego definition
2866fa8 
Signed-off-by: Jose Fuentes <jsfuentescastillo@gmail.com>
@j-fuentes @charlieegan3
Update pkg/reports/reports.go
589ac40 
Co-Authored-By: Charlie Egan <charlieegan3@users.noreply.github.com>
Signed-off-by: Jose Fuentes <jsfuentescastillo@gmail.com>
@jetstack-bot jetstack-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 29, 2020
@charlieegan3
Copy link
Contributor

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2020
@jetstack-bot jetstack-bot merged commit 111e1ba into jetstack:master Jan 30, 2020
@j-fuentes j-fuentes deleted the fail-if-missing branch January 30, 2020 10:52
This was referenced Jan 31, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlieegan3 charlieegan3 charlieegan3 left review comments

Assignees

@charlieegan3 charlieegan3

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@j-fuentes @charlieegan3 @jetstack-bot