Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove missing pod rules #73

Closed
wants to merge 1 commit into from
Closed

Remove missing pod rules #73

wants to merge 1 commit into from

Conversation

charlieegan3
Copy link
Contributor

@charlieegan3 charlieegan3 commented Jan 31, 2020

Needed after #68

#74 is a note about implementing these in the future so we don't forget them 馃槂

@jetstack-bot jetstack-bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Jan 31, 2020
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: charlieegan3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 31, 2020
Needed after #68

Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com>
@j-fuentes
Copy link
Member

Those rules are making use of the manual property. The problem is that is not really taken into account.

As an alternative to deleting them, I suggest that, at the moment, we omit the rules with manual: true when the reports are being created.

@charlieegan3
Copy link
Contributor Author

Thanks for opening an issue for the manual rules. I think this is low priority but something we can keep in the backlog.

These are causing issues today as it's not something which is handled (hence the PR)

With #74 and #76 open to keep tabs on the issue, my feeling is that this can perhaps go in as is and we can return to the issue when (if) it's deemed a priority in the future?

@wwwil
Copy link
Member

wwwil commented Feb 4, 2020

This PR I submitted should resolve this issue without needing to remove any rules: #77

@charlieegan3
Copy link
Contributor Author

I think #77 does indeed fix this, so closing.

@charlieegan3 charlieegan3 deleted the remove-missing-rules branch February 4, 2020 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants