Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't mark manual rules without Rego as missing #77

Merged
merged 2 commits into from
Feb 5, 2020

Conversation

wwwil
Copy link
Member

@wwwil wwwil commented Feb 3, 2020

Rules that are marked as manual should not be flagged as missing if they don't have Rego implementation as they are not supposed to.

Closes #76.

Signed-off-by: wwwil wwwil.squires@gmail.com

Signed-off-by: wwwil <wwwil.squires@gmail.com>
@jetstack-bot jetstack-bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Feb 3, 2020
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wwwil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 3, 2020
@j-fuentes
Copy link
Member

+1 to this change, but I don't think this closes #76.

Currently api.Report does not contain Manual, which means it is impossible to tell if a rule failed or it requires a manual check.

I suggest either filtering out manual rules from the report or surfacing the Manual.

Signed-off-by: wwwil <wwwil.squires@gmail.com>
@jetstack-bot jetstack-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 3, 2020
@wwwil
Copy link
Member Author

wwwil commented Feb 3, 2020

Currently api.Report does not contain Manual

The api. ReportRule has a Manual field: https://github.com/jetstack/preflight/blob/master/api/report.go#L81

I think the next issue is that we need to update the web UI to show manual rules differently, or at least highlight that they are manual.

@wwwil wwwil mentioned this pull request Feb 4, 2020
@j-fuentes
Copy link
Member

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 5, 2020
@jetstack-bot jetstack-bot merged commit 33cfa96 into jetstack:master Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not report rules marked as manual
3 participants