Skip to content
This repository has been archived by the owner on Aug 26, 2021. It is now read-only.

Explain a little Nginx Ingress config #22

Open
wernight opened this issue Aug 31, 2016 · 0 comments
Open

Explain a little Nginx Ingress config #22

wernight opened this issue Aug 31, 2016 · 0 comments

Comments

@wernight
Copy link
Contributor

kube-lego/examples/nginx/20-nginx-configmap.yaml contains a lot of overrides of the default values.

It's worth putting a comment for each to mark:

  • Is it optional or required?
  • Why do you suggest to override it?
@simonswine simonswine added this to the 0.2 milestone Sep 29, 2016
@simonswine simonswine removed this from the 0.2 milestone Jan 19, 2018
ElvinEfendi added a commit to Shopify/kube-lego that referenced this issue Feb 3, 2018
@ElvinEfendi
Merge pull request jetstack#22 from Shopify/dont-crash
705d421 
do not crash when decoded private key data does not include PEM data
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wernight @simonswine