This repository has been archived by the owner on Aug 26, 2021. It is now read-only.
Add ability to customize ingress class #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gianrubio
force-pushed
the
specify-ingress
branch
3 times, most recently
from
b327a4b
to
d7f6045
Compare
|
Sorry there is a rebase needed. Otherwise looking good and mergeable |
gianrubio
force-pushed
the
specify-ingress
branch
from
d7f6045
to
51371bf
Compare
|
@simonswine done! |
|
@gianrubio thanks will have to fix master first, but then will merge right away |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm restricting my ingresses to internal and external traffic. To do this, I'm running 2 ingress with [ingress--class] (https://github.com/kubernetes/ingress/blob/6cd21f7dea61e4df694d62857d5ea31f442962ce/core/pkg/ingress/controller/launch.go#L43) option.
When I finished the setup, I realise that kube-lego start ignoring my certificates with this message below.
This PR add the ability to kube-lego to work with different class (default: nginx,gce).
Ex:
LEGO_SUPPORTED_INGRESS_CLASS="intern,extern,nginx,custom"