Skip to content
This repository has been archived by the owner on Aug 26, 2021. It is now read-only.

WIP: Add dns challenge support #116

Closed
wants to merge 2 commits into from

Conversation

gianrubio
Copy link
Contributor

@gianrubio gianrubio commented Mar 24, 2017

POC for supporting dns challenge
Write a provider for route53

This is WIP, please don't merge!
Fix #26

Write a provider for route53
@gianrubio gianrubio changed the title WIP: Add support for dns challenge WIP: Add dns challenge support Mar 24, 2017
@gianrubio gianrubio mentioned this pull request Mar 24, 2017
@gianrubio
Copy link
Contributor Author

I didn't add aws vendor repo to make easy to compare the changes, to run this POC run dep ensure --update

@jetstack-bot
Copy link
Collaborator

@gianrubio: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@totemcaf
Copy link

Hi @gianrubio, I'm very interested in this feature. Is there any news on it, can I help?

@munnerz
Copy link
Contributor

munnerz commented Jan 26, 2018

Given the status of kube-lego (EoL), we won't be adding DNS support to this project.

Instead, please have a look at cert-manager. It supports ACME DNS validation as well as HTTP, as well as a number of other features.

Thanks for putting the work together initially @gianrubio, and sorry this PR wasn't looked at. I'm going to close this now as we won't be accepting new features into kube-lego.

@munnerz munnerz closed this Jan 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants