Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Changing CassandraCluster persistence settings should not be allowed #233

Closed
wallrj opened this issue Feb 1, 2018 · 1 comment · Fixed by #283
Closed

Changing CassandraCluster persistence settings should not be allowed #233

wallrj opened this issue Feb 1, 2018 · 1 comment · Fixed by #283
Assignees
@kragniz
Labels
area/cassandra kind/bug
Milestone
v0.1

Comments

@wallrj
Copy link
Member

wallrj commented Feb 1, 2018 •
edited

Right now, if you change the persistence settings for a running cluster, the navigator controller will attempt to update the statefulset with the new volumeclaimtemplate settings.

I'm not sure whether this is supported and even if so, Navigator doesn't yet have a way to control the rollout of the updated statefulset.

We should prevent the user from changing the persistence setting for now.

See:

/kind bug
@wallrj wallrj mentioned this issue Feb 1, 2018
Closed
@munnerz munnerz added this to the v0.1 milestone Feb 13, 2018
@wallrj
Copy link
Member Author

wallrj commented Feb 27, 2018

This shouldn't happen after #256 but we can add validation to make the persistence setting immutable.
Similar to what @kragniz did for Rack and DC

@wallrj wallrj changed the title Changing CassandraCluster persistence settings may cause data loss Changing CassandraCluster persistence settings should not be allowed Feb 27, 2018
@kragniz kragniz mentioned this issue Mar 13, 2018
Merged
jetstack-ci-bot added a commit that referenced this issue Mar 14, 2018
@jetstack-ci-bot
Merge pull request #283 from kragniz/immutable-persistence-settings
8aea20c 
Automatic merge from submit-queue.

Make nodepool persistence settings immutable

**What this PR does / why we need it**: this adds validation to not allow changing persistence settings in cassandra and elasticsearch, and adds test coverage for the update validation.

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #233

**Release note**:

```release-note
none
```
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kragniz kragniz

Labels
area/cassandra kind/bug
Projects
None yet
Milestone
v0.1
Development

Successfully merging a pull request may close this issue.

Make nodepool persistence settings immutable kragniz/navigator
4 participants
@munnerz @kragniz @wallrj @jetstack-bot