Use the Docker maintained Cassandra 3 image #229
Conversation
wallrj
changed the title
* Use the Docker maintained Cassandra 3 image. * Temporarily use TCP connect based readiness and liveness probes because this image doesn't contain a nodetool based `/ready-probe.sh` script. * I found that these TCP connection checks succeed even when the process is SIGSTOPped; so I now simulate a node failure using `nodetool decommission` which makes cassandra stop listening on its CQL port. * Cluster status aware readiness probes will be restored jetstack#170 is merged. Fixes: jetstack#222
wallrj
force-pushed
the
222-docker-cassandra-image
branch
from
3ffe4e2
to
186f8ba
Compare
| tag: {{ .Values.image.tag }} | ||
| pullPolicy: {{ .Values.image.pullPolicy }} | ||
| repository: {{ .Values.image.repository | quote }} | ||
| tag: {{ .Values.image.tag | quote }} |
There was a problem hiding this comment.
I got helm lint errors when I used an unquoted integer here.
https://github.com/kubernetes/helm/blob/master/docs/charts_tips_and_tricks.md#quote-strings-dont-quote-integers suggests quoting all strings, so I decided to do that.
| { | ||
| Name: "CASSANDRA_AUTO_BOOTSTRAP", | ||
| Value: "false", | ||
| }, |
There was a problem hiding this comment.
The Docker image doesn't pay attention to this environment variable so I removed it.
We'll see if it causes any dataloss problems when I rebase #225
| // The /run.sh script is unique to gcr.io/google-samples/cassandra:v12. | ||
| // TODO: Add support for other Cassandra images with different entry points. | ||
| cmd := exec.Command("/run.sh") | ||
| cmd := exec.Command("/docker-entrypoint.sh") |
There was a problem hiding this comment.
I guess we’ll still have issues handling SIGTERM with this? Unless they have properly set up signal handling in this script.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: munnerz The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
/ready-probe.shscript.nodetool decommissionwhich makes cassandra stop listening on its CQL port.Fixes: #222
Release note: