Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Remove duplicate Int32Ptr and Int64Ptr functions #296

Merged
merged 1 commit into from
Mar 21, 2018

Conversation

wallrj
Copy link
Member

@wallrj wallrj commented Mar 21, 2018

In https://github.com/jetstack/navigator/pull/256/files#r174153467 @munnerz wrote:

Maybe it's time to create test/util/pointer to expose these common pointer-related functions for re-use. We've written this function so many times now

Release note:

NONE

@munnerz
Copy link
Contributor

munnerz commented Mar 21, 2018

/lgtm
/approve

@jetstack-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: munnerz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot merged commit 40c58ed into jetstack:master Mar 21, 2018
@wallrj wallrj deleted the shared-int-ptr branch March 21, 2018 13:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants