adding a periodic job for testing on eks cluster #512

RinkiyaKeDad · 2021-06-11T11:24:49Z

Signed-off-by: RinkiyaKeDad arshsharma461@gmail.com

Signed-off-by: RinkiyaKeDad <arshsharma461@gmail.com>

jetstack-bot · 2021-06-11T11:24:58Z

Hi @RinkiyaKeDad. Thanks for your PR.

I'm waiting for a jetstack member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: RinkiyaKeDad <arshsharma461@gmail.com>

RinkiyaKeDad · 2021-07-27T16:42:50Z

/release-note-none

Signed-off-by: Arsh Sharma <arshsharma461@gmail.com>

RinkiyaKeDad

Have a couple of doubts :)

RinkiyaKeDad · 2021-07-30T11:05:38Z

config/jobs/cert-manager/cert-manager-periodics.yaml

+  # extra_refs:
+  # - org: jetstack
+  #   repo: cert-manager
+  #   base_ref: master


What do these do? Are they needed?

It specifies what repository this Prow job clones when it runs.

Thanks! Would you also know where it clones the repo? For example right now when we run the golang image we are in /go at the start. So if we specify this, would we be inside /go/cert-manager or would we still be in /go but have the cert-manager folder already cloned for us?

From a quick check it's cloned at /home/prow/go/src/github.com/jetstack/cert-manager and Prow sets that as workingDir for the test container.

By workingDir do you mean that at the launch of the container we would be at /home/prow/go/src/github.com/jetstack/cert-manager? If yes, then if we add another repo would the first one be the workingDir?

By workingDir do you mean that at the launch of the container we would be at /home/prow/go/src/github.com/jetstack/cert-manager?

Yep- it's the the workingDir in the container spec.

If yes, then if we add another repo would the first one be the workingDir

Looking at the code here looks like that would happen by default, but it seems like we can also set work_dir: true for a particular ref to configure which one should become workingDir.
I've not tried cloning more than one myself.

RinkiyaKeDad · 2021-07-30T11:06:27Z

config/jobs/cert-manager/cert-manager-periodics.yaml

+  # labels:
+  #   preset-service-account: "true"
+  #   preset-dind-enabled: "true"
+  #   preset-bazel-remote-cache-enabled: "true"
+  #   preset-bazel-scratch-dir: "true"
+  #   preset-cloudflare-credentials: "true"
+  #   preset-venafi-tpp-credentials: "true"
+  #   preset-venafi-cloud-credentials: "true"


Which ones will we need?

RinkiyaKeDad · 2021-07-30T11:07:14Z

config/jobs/cert-manager/cert-manager-periodics.yaml

+  #   preset-venafi-cloud-credentials: "true"
+  spec:
+    containers:
+    - image: eu.gcr.io/jetstack-build-infra-images/bazelbuild:20210323-ad5071a-3.7.2


How do I specify the golang-aws image that we built here?

You will first need to add the infra to build that image so it gets pushed to Jetstack Build Infra images GCR and then you can get the image sha from there. So probably the commits that build the image need to go in a PR before the PR that adds this Prow job.

RinkiyaKeDad · 2021-07-30T11:07:50Z

config/jobs/cert-manager/cert-manager-periodics.yaml

+      - name: AWS_ACCESS_KEY_ID
+        value: "???"
+      - name: AWS_SECRET_ACCESS_KEY
+        value: "???"


We can't have the access keys on GitHub so how will this work?

It'll probably need to be a Secret in the cluster where the Prow job runs. The Prow job can then be configured to consume it via a preset like we do it with i.e Venafi creds- preset defined here and consumed added to the job here. (The actual Secret would need to be created in the cluster separately).

Signed-off-by: Arsh Sharma <arshsharma461@gmail.com>

RinkiyaKeDad

/hold because of things mentioned in the review.

RinkiyaKeDad · 2021-08-04T12:02:59Z

config/jobs/cert-manager/cert-manager-periodics.yaml

+    preset-aws-credentials: "true"
+  spec:
+    containers:
+    - image: <to-be-replaced>


RinkiyaKeDad · 2021-08-04T12:03:27Z

config/jobs/cert-manager/cert-manager-periodics.yaml

+        cd.. && \
+        cd.. && \
+        cd cert-manager && \
+        ./devel/run-e2e.sh --ginkgo.focus "Public ACME Server HTTP01 Issuer" --acme-server-url=https://acme-staging-v02.api.letsencrypt.org/directory --ingress-controller-domain=aws.e2e-tests.cert-manager.io --testing-acme-email=<need-to-replace-this> --kubernetes-config=../test-infra/aws/kubeconfig_cert-manager-cluster;


--testing-acme-email=<need-to-replace-this> this.

Signed-off-by: Arsh Sharma <arshsharma461@gmail.com>

RinkiyaKeDad · 2021-08-05T13:07:31Z

/unhold

jakexks · 2021-08-10T10:40:56Z

/ok-to-test

jakexks · 2021-08-10T10:57:02Z

/lgtm

jetstack-bot · 2021-08-10T10:57:21Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakexks, RinkiyaKeDad

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~config/jobs/cert-manager/OWNERS~~ [jakexks]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jetstack-bot · 2021-08-10T10:57:53Z

@RinkiyaKeDad: Updated the job-config configmap in namespace default at cluster default using the following files:

key cert-manager-periodics.yaml using file config/jobs/cert-manager/cert-manager-periodics.yaml
key config.yaml using file config/jobs/cert-manager/config.yaml

In response to this:

Signed-off-by: RinkiyaKeDad arshsharma461@gmail.com

/assign @jakexks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

initial commit

a3af154

Signed-off-by: RinkiyaKeDad <arshsharma461@gmail.com>

jetstack-bot assigned jakexks Jun 11, 2021

jetstack-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 11, 2021

RinkiyaKeDad added 2 commits June 25, 2021 11:35

added ginkgo stuff

c15f337

Signed-off-by: RinkiyaKeDad <arshsharma461@gmail.com>

installing aws cli and iam authenticator

6d89ff6

Signed-off-by: RinkiyaKeDad <arshsharma461@gmail.com>

jetstack-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 25, 2021

RinkiyaKeDad added 2 commits June 29, 2021 17:26

added regex in ginkgo command

2de4f81

Signed-off-by: RinkiyaKeDad <arshsharma461@gmail.com>

remove aws vars since auto passed

c3d07c2

Signed-off-by: RinkiyaKeDad <arshsharma461@gmail.com>

RinkiyaKeDad marked this pull request as draft July 3, 2021 05:17

updated command

bd85967

Signed-off-by: RinkiyaKeDad <arshsharma461@gmail.com>

RinkiyaKeDad changed the title ~~[WIP] adding a periodic job for testing on eks cluster~~ adding a periodic job for testing on eks cluster Jul 27, 2021

RinkiyaKeDad marked this pull request as ready for review July 27, 2021 14:33

jetstack-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 27, 2021

jetstack-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 27, 2021

RinkiyaKeDad added 4 commits July 30, 2021 11:49

docker image: aws-iam not working rest is

62c5f03

Signed-off-by: Arsh Sharma <arshsharma461@gmail.com>

iam-auth also working now

e6ef718

Signed-off-by: Arsh Sharma <arshsharma461@gmail.com>

image completed

ccb5999

Signed-off-by: Arsh Sharma <arshsharma461@gmail.com>

added image building job

cb58a15

Signed-off-by: Arsh Sharma <arshsharma461@gmail.com>

jetstack-bot added area/testing Indicates a PR related to testing needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 30, 2021

jetstack-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 30, 2021

RinkiyaKeDad commented Jul 30, 2021

View reviewed changes

RinkiyaKeDad mentioned this pull request Jul 30, 2021

adding image needed for aws tests #539

Merged

remove image building stuff

3934327

Signed-off-by: Arsh Sharma <arshsharma461@gmail.com>

jetstack-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 30, 2021

fix newline git diff

8725cb7

Signed-off-by: Arsh Sharma <arshsharma461@gmail.com>

jetstack-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 30, 2021

added preset for aws creds and finalized job

ff71654

Signed-off-by: Arsh Sharma <arshsharma461@gmail.com>

RinkiyaKeDad commented Aug 4, 2021

View reviewed changes

jetstack-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 4, 2021

added image and email to use for aws tests

00bb932

Signed-off-by: Arsh Sharma <arshsharma461@gmail.com>

jetstack-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 5, 2021

jetstack-bot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 10, 2021

jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 10, 2021

jakexks approved these changes Aug 10, 2021

View reviewed changes

jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2021

jetstack-bot merged commit 8e393cd into cert-manager:master Aug 10, 2021

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

adding a periodic job for testing on eks cluster #512

adding a periodic job for testing on eks cluster #512

RinkiyaKeDad commented Jun 11, 2021

jetstack-bot commented Jun 11, 2021

RinkiyaKeDad commented Jul 27, 2021

RinkiyaKeDad left a comment

RinkiyaKeDad Jul 30, 2021

irbekrm Jul 30, 2021

RinkiyaKeDad Jul 30, 2021

irbekrm Jul 30, 2021

RinkiyaKeDad Jul 30, 2021

irbekrm Jul 30, 2021 •

edited

Loading

RinkiyaKeDad Jul 30, 2021

RinkiyaKeDad Jul 30, 2021

irbekrm Jul 30, 2021 •

edited

Loading

RinkiyaKeDad Jul 30, 2021

irbekrm Jul 30, 2021

RinkiyaKeDad left a comment

RinkiyaKeDad Aug 4, 2021

RinkiyaKeDad Aug 4, 2021

RinkiyaKeDad commented Aug 5, 2021

jakexks commented Aug 10, 2021

jakexks commented Aug 10, 2021

jetstack-bot commented Aug 10, 2021

jetstack-bot commented Aug 10, 2021

adding a periodic job for testing on eks cluster #512

adding a periodic job for testing on eks cluster #512

Conversation

RinkiyaKeDad commented Jun 11, 2021

jetstack-bot commented Jun 11, 2021

RinkiyaKeDad commented Jul 27, 2021

RinkiyaKeDad left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

irbekrm Jul 30, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

irbekrm Jul 30, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

RinkiyaKeDad left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

RinkiyaKeDad commented Aug 5, 2021

jakexks commented Aug 10, 2021

jakexks commented Aug 10, 2021

jetstack-bot commented Aug 10, 2021

jetstack-bot commented Aug 10, 2021

irbekrm Jul 30, 2021 •

edited

Loading

irbekrm Jul 30, 2021 •

edited

Loading