Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rewrite prevents URL session tracking. #4329

Closed
gregw opened this issue Nov 19, 2019 · 2 comments · Fixed by #4337
Closed

rewrite prevents URL session tracking. #4329

gregw opened this issue Nov 19, 2019 · 2 comments · Fixed by #4337
Assignees
@joakime
Labels
Bug For general bugs on Jetty side
Projects
Jetty 9.4.25

Comments

@gregw
Copy link
Contributor

gregw commented Nov 19, 2019

Jetty version
9.4.23
Java version
any
OS type/version
any
Description

The rewrite rules as configured for the demo webapp in a jetty distribution remove URI parameters so that session tracking by URI does not work.
Ideally rewrite should be able to be used without preventing URL session tracking.... even if it has to be a special rule to extract and remember the jsessionid somehow.
@joakime joakime added the Bug For general bugs on Jetty side label Nov 19, 2019
@joakime
Copy link
Contributor

joakime commented Nov 19, 2019 •
edited

I cannot get /test/session example to work as expected in any past release of Jetty.

Versions of Jetty tested ...

  • 9.4.22.v20191022
  • 9.4.21.v20190610
  • 9.4.14.v20181114
  • 9.3.25.v20180904
  • 9.2.27.v20190403
  • 9.2.5.v20141112
  • 9.1.5.v20140526

This issue is old, and not unique to the staged 9.4.23

joakime added a commit that referenced this issue Nov 19, 2019
@joakime
Issue #4329 - New testcase for demo-base /test/session/
4d10318 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
@joakime joakime added this to To do in Jetty 9.4.24 via automation Nov 19, 2019
@joakime joakime moved this from To do to In progress in Jetty 9.4.24 Nov 19, 2019
@joakime joakime mentioned this issue Nov 20, 2019
Closed
joakime added a commit that referenced this issue Nov 20, 2019
@joakime
Issue #4329 - Fixing RuleContainer to handle path parameters
09641c9 
+ Introducing HttpURI.setParam(String)
+ Updating DemoBaseTest.testSessionDump() to follow expected behavior

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
@joakime joakime mentioned this issue Nov 20, 2019
Merged
@joakime
Copy link
Contributor

joakime commented Nov 20, 2019

Opened PR #4337

@joakime joakime removed this from In progress in Jetty 9.4.24 Nov 20, 2019
@joakime joakime added this to To do in Jetty 9.4.25 via automation Nov 20, 2019
@joakime joakime moved this from To do to In progress in Jetty 9.4.25 Nov 20, 2019
@joakime joakime mentioned this issue Nov 20, 2019
Closed
joakime added a commit that referenced this issue Nov 27, 2019
@joakime
Issue #4329 - Cleaning up SessionDump
15c9f0b 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
Jetty 9.4.25 automation moved this from In progress to Done Nov 27, 2019
joakime added a commit that referenced this issue Nov 27, 2019
@joakime
Merge pull request #4337 from eclipse/jetty-9.4.x-4329-rewrite-rules-…
380cebc 
…demobase

Issue #4329 - Fixing RuleContainer to handle path parameters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joakime joakime

Labels
Bug For general bugs on Jetty side
Projects
No open projects
Jetty 9.4.25
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #4329 - Fixing RuleContainer to handle path parameters jetty/jetty.project
2 participants
@gregw @joakime