Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo rewrite rules prevent URL Session tracking #2675

Closed
gregw opened this issue Jun 19, 2018 · 6 comments
Closed

Demo rewrite rules prevent URL Session tracking #2675

gregw opened this issue Jun 19, 2018 · 6 comments

Comments

@gregw
Copy link
Contributor

gregw commented Jun 19, 2018

One of the rewrite rules used in the demo-base is removing the URL parameters so that session URL tracking cannot be used.

@joakime
Copy link
Contributor

joakime commented Jun 19, 2018

None of the rewrite rules seem to do that.

https://github.com/eclipse/jetty.project/blob/jetty-9.4.x/tests/test-webapps/test-jetty-webapp/src/main/config/demo-base/etc/demo-rewrite-rules.xml

Are you sure they are not being removed by something within the ServletContext?

@joakime
Copy link
Contributor

joakime commented Jun 19, 2018

Can't find anything in the webapps deployed with demo-base that remove the URL session tracking.

What did you do to setup Session tracking?

@joakime
Copy link
Contributor

joakime commented Jun 19, 2018

There's no override descriptor or custom default descriptor that changes it.
There's also no webapps/<context>.xml content that modifies it as well.

@joakime
Copy link
Contributor

joakime commented Jun 19, 2018

Found it.

This block of code eliminates the request parameters.

https://github.com/eclipse/jetty.project/blob/4f544475853b1e1a7d8bdb161fe7bb34b5a3a3ff/jetty-rewrite/src/main/java/org/eclipse/jetty/rewrite/handler/RuleContainer.java#L187-L194

So, if the RuleContainer exists, and has at least 1 rule, and is using default RewriteHandler configuration, the request URL parameters are removed by that block of code.

joakime added a commit that referenced this issue Jun 19, 2018
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
@joakime joakime removed their assignment Sep 11, 2018
@stale
Copy link

stale bot commented Nov 20, 2019

This issue has been automatically marked as stale because it has been a full year without activit. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale For auto-closed stale issues and pull requests label Nov 20, 2019
@joakime
Copy link
Contributor

joakime commented Nov 20, 2019

Closing in favor of #4329

@joakime joakime closed this as completed Nov 20, 2019
@joakime joakime removed the Stale For auto-closed stale issues and pull requests label Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants