Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review need for MultiParts interface in jetty-10 #4368

Closed
janbartel opened this issue Nov 27, 2019 · 0 comments
Closed

Review need for MultiParts interface in jetty-10 #4368

janbartel opened this issue Nov 27, 2019 · 0 comments
Assignees
@lachlan-roberts
Labels
Low Priority Task
Milestone
10.0.x

Comments

@janbartel
Copy link
Contributor

jetty-10

Review the need for the MultiParts interface in jetty-10: there does not seem to be any need for this class any more, as it looks like the legacy parser is gone.
@janbartel janbartel added this to the 10.0.x milestone Nov 27, 2019
lachlan-roberts added a commit to lachlan-roberts/jetty.project that referenced this issue Nov 27, 2019
@lachlan-roberts
Issue jetty#4368 - make MultiParts a class instead of interface
e9ad3dd 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit to lachlan-roberts/jetty.project that referenced this issue Nov 27, 2019
@lachlan-roberts
Issue jetty#4368 - make MultiParts a class instead of interface
ba7158b 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit to lachlan-roberts/jetty.project that referenced this issue Nov 27, 2019
@lachlan-roberts
Issue jetty#4368 - make MultiParts a class instead of interface
6988c4f 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@lachlan-roberts lachlan-roberts mentioned this issue Nov 27, 2019
Merged
lachlan-roberts added a commit to lachlan-roberts/jetty.project that referenced this issue Nov 27, 2019
@lachlan-roberts
Issue jetty#4368 directly use MultiPartFormInputStream instead of Mul…
76bb8d2 
…tiParts

MultiPart cleanup is now done in Request.onCompleted()

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit that referenced this issue Nov 27, 2019
@lachlan-roberts
Merge pull request #4371 from lachlan-roberts/jetty-10.0.x-4368-Multi…
e8746ec 
…PartsReview

Issue #4368 - remove MultiParts interface and simplify MultiPart cleanup
@janbartel janbartel mentioned this issue Dec 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lachlan-roberts lachlan-roberts

Labels
Low Priority Task
Projects
None yet
Milestone
10.0.x
Development

No branches or pull requests
2 participants
@janbartel @lachlan-roberts