Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #4368 - remove MultiParts interface and simplify MultiPart cleanup #4371

Conversation

lachlan-roberts
Copy link
Contributor

@lachlan-roberts lachlan-roberts commented Nov 27, 2019

Issue #4368

Removed the MultiParts interface which was used to switch between the MultiPart parser implementations.

The request attribute storing MultiParts has now been removed and the Multipart cleanup is now done in the Request.onCompleted().

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
…tiParts

MultiPart cleanup is now done in Request.onCompleted()

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@lachlan-roberts lachlan-roberts changed the title Issue #4368 - make MultiParts a class instead of interface Issue #4368 - remove MultiParts interface and simplify MultiPart cleanup Nov 27, 2019
Copy link
Contributor

@janbartel janbartel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lachlan-roberts lachlan-roberts merged commit e8746ec into jetty:jetty-10.0.x Nov 27, 2019
@lachlan-roberts lachlan-roberts deleted the jetty-10.0.x-4368-MultiPartsReview branch November 27, 2019 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants