Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read JAVA_OPTIONS in jetty.sh #8153

Merged
merged 1 commit into from
Jun 22, 2022

Conversation

fanf
Copy link
Contributor

@fanf fanf commented Jun 9, 2022

Fixes #8152

@joakime
Copy link
Contributor

joakime commented Jun 9, 2022

This is not necessary, as the JAVA_OPTIONS carries over to the JVM itself without reference on the command line.

Also, since a forked JVM is highly possible, it's recommended that you put what used to be in JAVA_OPTIONS is now in your ${jetty.base}/start.d/exec.ini (once you have the --add-module=exec called)

@fanf
Copy link
Contributor Author

fanf commented Jun 9, 2022

Oh. The paramaters where not taken into account anymore without that change.
But OK, there must be something else happening. I will look at the exec.ini option.
Thanks, and sorry for the noise then

@joakime
Copy link
Contributor

joakime commented Jun 9, 2022

Don't worry about it.
This feels like a harmless addition to jetty.sh, so I'm leaning towards merging it.
Just testing a few different scenarios where the $JAVA_OPTIONS and ${jetty.base}/start.d/exec.ini conflict and see what happens.

@joakime
Copy link
Contributor

joakime commented Jun 15, 2022

@fanf we need you to have a valid Eclipse ECA so we can merge this.

@fanf
Copy link
Contributor Author

fanf commented Jun 16, 2022

Sorry for the delay, it is now done

@fanf
Copy link
Contributor Author

fanf commented Jun 16, 2022

Hum, no, email inconsistency, let me do that again

@fanf
Copy link
Contributor Author

fanf commented Jun 16, 2022

OK, done for real

@joakime joakime self-assigned this Jun 22, 2022
@joakime joakime merged commit 2dfbea1 into jetty:jetty-10.0.x Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jetty.sh does not read JAVA_OPTIONS anymore
2 participants