Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HealthCheck OK but none of REPL, TypeQuery and Concealing works #11

Closed
Huxpro opened this issue Sep 7, 2018 · 13 comments
Closed

HealthCheck OK but none of REPL, TypeQuery and Concealing works #11

Huxpro opened this issue Sep 7, 2018 · 13 comments

Comments

@Huxpro
Copy link
Contributor

Huxpro commented Sep 7, 2018

screen shot 2018-09-06 at 10 07 55 pm

Health Check

screen shot 2018-09-06 at 10 07 08 pm

Type Query (I'm new to SML so I was just using auto_gen = 'always' and try with a single file, I do see *.du* get generated under the same dir.

screen shot 2018-09-06 at 10 07 29 pm

Hmm no idea what happened. It does look like a syntax error from somewhere.

screen shot 2018-09-06 at 10 11 14 pm

concealing

screen shot 2018-09-06 at 10 11 51 pm

my .vimrc for vimbettersml (basically copy from README)

I wasn't sure what I did wrong, but thanks for the plugin in advance!

@jez
Copy link
Owner

jez commented Sep 7, 2018

Ha, I just implemented this a few days ago and then didn’t have time to finish it. I’ll take a look later tonight, so thanks for your patience! In the mean time you might want to checkout an older commit to use. For example:

7530bbb

Is the first commit before any of the recent changes.

@jez
Copy link
Owner

jez commented Sep 7, 2018

Also, could you paste the output of vim --version?

@jez
Copy link
Owner

jez commented Sep 7, 2018

I just pushed a fix for the first bug (:SMLCheckHealth should work without errors.)

I'm looking to see what's up with the type query.

@jez
Copy link
Owner

jez commented Sep 7, 2018

Ah, the :SMLReplStart failed because you're not using neither Neovim nor tmux + benmills/vimux, one of which is required to use the REPL.

I haven't gotten around to supporting Vim 8 yet, because I personally use Neovim when I tried to figure out how to launch a terminal session in Vim 8, it seemed not to hang.

Hypothetically adding another REPL backend should not be too hard. If you're familiar with writing Vim plugins I'm happy to answer questions about where to start if you wanted to implement Vim 8 support.

@jez
Copy link
Owner

jez commented Sep 7, 2018

As for why conceallevel isn't working, you'll want to check the output of your vim --version:

vim --version | grep conceal

If you see a + next to conceal, that means it's supported.
If you see either -conceal or no output, that means it's not supported.

Vim can be built with certain features turned on or off, so if you don't see it, you'll want to recompile / reinstall a different version of Vim for your platform.

@jez
Copy link
Owner

jez commented Sep 7, 2018

So to recap:

If you pull the most recent version of the plugin, all the issues above should either be fixed, or else I think they're issues with your particular Vim setup.

Happy to help walk you through anything else!

@Huxpro
Copy link
Contributor Author

Huxpro commented Sep 7, 2018

Thx for the detailed replies! Yep, I am using vim 8 and here is the vim --version. Looks like conceal is supported tho.

VIM - Vi IMproved 8.0 (2016 Sep 12, compiled Feb  8 2018 23:41:19)
macOS version
Included patches: 1-1450
Compiled by Homebrew
Huge version without GUI.  Features included (+) or not (-):
+acl               +farsi             +mouse_sgr         -tag_any_white
+arabic            +file_in_path      -mouse_sysmouse    -tcl
+autocmd           +find_in_path      +mouse_urxvt       +termguicolors
-autoservername    +float             +mouse_xterm       +terminal
-balloon_eval      +folding           +multi_byte        +terminfo
+balloon_eval_term -footer            +multi_lang        +termresponse
-browse            +fork()            -mzscheme          +textobjects
++builtin_terms    -gettext           +netbeans_intg     +timers
+byte_offset       -hangul_input      +num64             +title
+channel           +iconv             +packages          -toolbar
+cindent           +insert_expand     +path_extra        +user_commands
-clientserver      +job               +perl              +vertsplit
+clipboard         +jumplist          +persistent_undo   +virtualedit
+cmdline_compl     +keymap            +postscript        +visual
+cmdline_hist      +lambda            +printer           +visualextra
+cmdline_info      +langmap           +profile           +viminfo
+comments          +libcall           +python            +vreplace
+conceal           +linebreak         -python3           +wildignore
+cryptv            +lispindent        +quickfix          +wildmenu
+cscope            +listcmds          +reltime           +windows
+cursorbind        +localmap          +rightleft         +writebackup
+cursorshape       -lua               +ruby              -X11
+dialog_con        +menu              +scrollbind        -xfontset
+diff              +mksession         +signs             -xim
+digraphs          +modify_fname      +smartindent       -xpm
-dnd               +mouse             +startuptime       -xsmp
-ebcdic            -mouseshape        +statusline        -xterm_clipboard
+emacs_tags        +mouse_dec         -sun_workshop      -xterm_save
+eval              -mouse_gpm         +syntax
+ex_extra          -mouse_jsbterm     +tag_binary
+extra_search      +mouse_netterm     +tag_old_static

@Huxpro
Copy link
Contributor Author

Huxpro commented Sep 8, 2018

I was able to get concealing works by setting the conceal_level out of augroup. Not sure why.

@Huxpro
Copy link
Contributor Author

Huxpro commented Sep 8, 2018

I have switched to neovim and :SMLReplyBlah now works perfectly! I heard it for a while but didn't have a chance to try it ;)

@Huxpro
Copy link
Contributor Author

Huxpro commented Sep 8, 2018

What I care most about is actually TypeQuery.

I am new to SML ecosystem so I am not sure I understand what really is.MLB file...I was trying to read http://mlton.org/MLBasis but not quite get it.

I thought ML Basis Library is more like a standard library having been built into the compiler? But it sounds like some metafile to describe the project itself?

@jez
Copy link
Owner

jez commented Sep 8, 2018 via email

@jez
Copy link
Owner

jez commented Sep 8, 2018 via email

@Huxpro
Copy link
Contributor Author

Huxpro commented Sep 8, 2018

@jez Gotcha! That's very clear and helpful ;)

I'm gonna close this issue. Thx for your great works!

@Huxpro Huxpro closed this as completed Sep 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants