Implement a macro to help implement GstElements #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were overflowing when calculating the "generated_prop_id", let it be
negative when setting/getting a manually added property:
```
thread 'object_inner_methods' panicked at 'attempt to subtract with overflow', /rustc/a8314ef7d0ec7b75c336af2c9857bfaf43002bfc/library/core/src/ops/arith.rs:240:1
stack backtrace:
0: rust_begin_unwind
at /rustc/a8314ef7d0ec7b75c336af2c9857bfaf43002bfc/library/std/src/panicking.rs:584:5
1: core::panicking::panic_fmt
at /rustc/a8314ef7d0ec7b75c336af2c9857bfaf43002bfc/library/core/src/panicking.rs:142:14
2: core::panicking::panic
at /rustc/a8314ef7d0ec7b75c336af2c9857bfaf43002bfc/library/core/src/panicking.rs:48:5
3: <usize as core::ops::arith::Sub>::sub
at /rustc/a8314ef7d0ec7b75c336af2c9857bfaf43002bfc/library/core/src/ops/arith.rs:233:45
4: <usize as core::ops::arith::Sub<&usize>>::sub
at /rustc/a8314ef7d0ec7b75c336af2c9857bfaf43002bfc/library/core/src/internal_macros.rs:61:17
5: <object::obj_inner::ObjInner as glib::subclass::object::ObjectImpl>::property
at ./tests/object.rs:56:1
6: glib::subclass::object::property
at /var/home/thiblahute/devel/misc/gtk-rs-core/glib/src/subclass/object.rs:80:13
7: g_object_get_property
8: <T as glib::object::ObjectExt>::try_property_value
at /var/home/thiblahute/devel/misc/gtk-rs-core/glib/src/object.rs:2515:13
9: <T as glib::object::ObjectExt>::try_property
at /var/home/thiblahute/devel/misc/gtk-rs-core/glib/src/object.rs:2485:20
10: <T as glib::object::ObjectExt>::property
at /var/home/thiblahute/devel/misc/gtk-rs-core/glib/src/object.rs:2493:9
11: object::object_inner_methods
at ./tests/object.rs:134:16
12: object::object_inner_methods::{{closure}}
at ./tests/object.rs:125:1
13: core::ops::function::FnOnce::call_once
at /rustc/a8314ef7d0ec7b75c336af2c9857bfaf43002bfc/library/core/src/ops/function.rs:248:5
14: core::ops::function::FnOnce::call_once
at /rustc/a8314ef7d0ec7b75c336af2c9857bfaf43002bfc/library/core/src/ops/function.rs:248:5
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
```
thiblahute
force-pushed
the
gst
branch
4 times, most recently
from
c57767e
to
bc61518
Compare
|
I decided to move that into [ Closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Includes #30 and #29)
Started to port some GStreamer elements to it here: https://gitlab.freedesktop.org/thiblahute/gst-plugins-rs/-/commits/port_to_gobject
Fixes: #25