-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WASM SUpport - Take II #1710
WASM SUpport - Take II #1710
Conversation
e274494
to
160c38f
Compare
160c38f
to
466c498
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please reply to nits
@@ -11,7 +11,7 @@ | |||
|
|||
#if !defined(EVE_ABI_DETECTED) | |||
# define EVE_CURRENT_ABI ::eve::emulated_ | |||
# define EVE_CURRENT_API ::eve::cpu_ | |||
# define EVE_CURRENT_API ::eve::undefined_simd_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this change?
template<auto Version> | ||
inline bool is_supported(spy::wasm_simd_info<Version> const&) noexcept | ||
{ | ||
#if defined(EVE_HW_WASM) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
current_api >= eve::wasm?
{ | ||
static constexpr std::size_t general = 2 * sizeof(void *); | ||
static constexpr std::size_t simd = 2 * sizeof(void *); | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you remind me what this is? especially * sizeof(void *)? are you being too cute with no comments?
{ | ||
using type = wide<T, N>; | ||
return self ^= type {bit_cast(other, as<T> {})}; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why you don't forward to cpu for hese ones
Will redo this when we update the CI with newer compilers |
No description provided.