WASM SUpport - Take II #1710
Open
WASM SUpport - Take II #1710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfalcou
force-pushed
the
feat/wasm-support
branch
2 times, most recently
from
e274494
to
160c38f
Compare
jfalcou
force-pushed
the
feat/wasm-support
branch
from
160c38f
to
466c498
Compare
DenisYaroshevskiy
approved these changes
Dec 20, 2023
| @@ -11,7 +11,7 @@ | |||
|
|
|||
| #if !defined(EVE_ABI_DETECTED) | |||
| # define EVE_CURRENT_ABI ::eve::emulated_ | |||
| # define EVE_CURRENT_API ::eve::cpu_ | |||
| # define EVE_CURRENT_API ::eve::undefined_simd_ | |||
There was a problem hiding this comment.
why this change?
| template<auto Version> | ||
| inline bool is_supported(spy::wasm_simd_info<Version> const&) noexcept | ||
| { | ||
| #if defined(EVE_HW_WASM) |
There was a problem hiding this comment.
current_api >= eve::wasm?
| { | ||
| static constexpr std::size_t general = 2 * sizeof(void *); | ||
| static constexpr std::size_t simd = 2 * sizeof(void *); | ||
| }; |
There was a problem hiding this comment.
can you remind me what this is? especially * sizeof(void *)? are you being too cute with no comments?
| { | ||
| using type = wide<T, N>; | ||
| return self ^= type {bit_cast(other, as<T> {})}; | ||
| } |
There was a problem hiding this comment.
why you don't forward to cpu for hese ones
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.